packages/ui/src/rich-text-area/rich-text-toolbar.tsx (1)

153-169: Critical: Link insertion and removal is completely disabled.

Both setLink() and unsetLink() commands are commented out. Users cannot add or remove links from selected text. The link button is rendered and can be clicked, but the prompt appears without any effect on the editor.

Restore the functionality:

       const url = window.prompt("Link URL", previousUrl);

       if (!url?.trim()) {
-        editor.commands.focus();
-        editor.commands.extendMarkRange("link");
-        // editor.commands.unsetLink();
+        editor.chain().focus().extendMarkRange("link").unsetLink().run();
         return;
       }

-      editor.commands.focus();
-      editor.commands.extendMarkRange("link");
-      // editor.commands.setLink({ href: url });
+      editor.chain().focus().extendMarkRange("link").setLink({ href: url }).run();

packages/ui/src/rich-text-area/rich-text-provider.tsx (1)

125-200: I need to inspect the actual file to verify the review comment's accuracy and the recommended fix.

I need to examine the actual file to verify the review comment's accuracy and the recommended fix.

Based on my verification using web searches and documentation, I can now provide a definitive assessment of the review comment.

Critical: as any suppresses type safety instead of fixing the underlying issue.

The use of as any type assertion for TipTap extensions is acknowledged as "not a great solution" but is used as a workaround. The extensions array with conditional spreading creates type inference challenges that TipTap reports as type assignment errors.

The recommended solution aligns with TipTap best practices. The issue stems from the extensions property expected by useEditor being a straightforward array of extensions, not a complex conditional array. Removing the as any assertion and properly typing the array is the correct approach.

Recommended solution:

Remove the as any assertion and the wrapping parentheses. The extensions array should be:

-     extensions: ([
+     extensions: [
        ...(markdown ? [Markdown] : []),
        StarterKit.configure({
          heading: features.includes("headings")
            ? {
                levels: [1, 2],
              }
            : false,
          bold: features.includes("bold") ? undefined : false,
          italic: features.includes("italic") ? undefined : false,
          link: features.includes("links") ? undefined : false,
        }),
        Placeholder.configure({
          placeholder,
          emptyEditorClass:
            "before:content-[attr(data-placeholder)] before:float-left before:text-content-muted before:h-0 before:pointer-events-none",
        }),

        // Images
        ...(features.includes("images") && handleImageUpload
          ? [
              Image.configure({
                inline: false,
                HTMLAttributes: {
                  class: "rounded-lg max-w-full h-auto",
                },
              }),
              FileHandler.configure({
                allowedMimeTypes: [
                  "image/png",
                  "image/jpeg",
                  "image/gif",
                  "image/webp",
                ],
                onDrop: (currentEditor, files, pos) => {
                  files.forEach((file) =>
                    handleImageUpload(file, currentEditor, pos),
                  );
                },
                onPaste: (currentEditor, files, htmlContent) => {
                  if (htmlContent) return false;
                  files.forEach((file) =>
                    handleImageUpload(
                      file,
                      currentEditor,
                      currentEditor.state.selection.anchor,
                    ),
                  );
                },
              }),
            ]
          : []),
        ...(features.includes("variables") && variables
          ? [
              Mention.extend({
                renderHTML({ node }: { node: any }) {
                  return [
                    "span",
                    {
                      class:
                        "px-1 py-0.5 bg-blue-100 text-blue-700 rounded font-semibold",
                      "data-type": "mention",
                      "data-id": node.attrs.id,
                    },
                    `{{${node.attrs.id}}}`,
                  ];
                },
                renderText({ node }: { node: any }) {
                  return `{{${node.attrs.id}}}`;
                },
              }).configure({
                suggestion: suggestions(variables),
              }),
            ]
          : []),
-     ] as any),
+     ],

If TypeScript errors persist after this change, the actual type mismatch needs investigation. Check that TipTap package versions are compatible and consider adding an explicit type annotation if needed.