Only send ProgramPayoutThankYou to userWhoInitiatedPayout #3145

steven-tey · 2025-11-22T04:17:33Z

Summary by CodeRabbit

Bug Fixes
- Payout notification emails now only send when the initiating user has a valid email address.
Improvements
- Switched payout delivery from batch dispatch to individual sends for more reliable delivery.
- Updated email rendering to the new React-based template format.
- Enhanced logging of email delivery results for easier tracking and debugging.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

vercel · 2025-11-22T04:17:36Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Updated (UTC)
dub	Ready	Preview	Nov 22, 2025 4:22am

steven-tey · 2025-11-22T04:17:39Z

@coderabbitai full review

coderabbitai · 2025-11-22T04:17:44Z

✅ Actions performed

Full review triggered.

coderabbitai · 2025-11-22T04:17:47Z

Walkthrough

Replaces batch email queuing with individual sendEmail calls for payout notifications, adds a guard to only send when the initiating user has an email, switches to a React template invocation ProgramPayoutThankYou, and tightens user include filtering by userId.

Changes

Cohort / File(s)	Summary
Email dispatch and payout processing `apps/web/app/(ee)/api/cron/payouts/process/process-payouts.ts`	Removed `queueBatchEmail` usage and import; added `sendEmail` import. Send individual emails using `react: ProgramPayoutThankYou(...)`. Added guard to only send if initiating user has an email. Adjusted included users filter to `where: { userId }`. Log recipient email and JSON response after send.

Sequence Diagram

sequenceDiagram
    participant P as Payout Processor
    participant DB as Database (users/payouts)
    participant ES as Email Service
    participant C as Console Log

    P->>DB: fetch payout + included users (where: { userId })
    P->>P: identify userWhoInitiatedPayout = users[0]?.user
    alt user has email
        P->>ES: sendEmail({ react: ProgramPayoutThankYou(...), to: user.email })
        ES-->>P: send response (JSON)
        P->>C: log recipient & response
    else no email
        Note over P: skip sending email
    end

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Verify correct props passed to ProgramPayoutThankYou and that React template rendering is supported by sendEmail.
Confirm the guard correctly handles absent emails and that the userId include filter matches intended query semantics.
Check logging does not leak sensitive data.

Possibly related PRs

Add program payout thank you email template #3132: Earlier change that introduced the ProgramPayoutThankYou template and batch-email usage in the same payout processing file.
Add batch email processing functionality #3011: Prior modification to this file that altered the email sending approach; closely related to the current refactor.

Suggested reviewers

devkiran

Poem

🐰 A Rabbit's Note of Thanks

Each payout hops out one by one,
No bundled mail to cloud the sun,
A template blooms with every send,
Guarded hops from start to end,
I nibble logs and cheer—well done! 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Only send ProgramPayoutThankYou to userWhoInitiatedPayout' directly and specifically describes the main change: restricting the payout thank you email to only the user who initiated the payout.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch improve-payout-thank-you

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4512e06 and ad6ee04.

📒 Files selected for processing (1)

apps/web/app/(ee)/api/cron/payouts/process/process-payouts.ts (4 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-10-28T19:17:44.390Z

Learnt from: TWilson023
Repo: dubinc/dub PR: 2985
File: apps/web/app/(ee)/api/network/programs/[programSlug]/route.ts:32-37
Timestamp: 2025-10-28T19:17:44.390Z
Learning: In Prisma queries, the `include` clause is only used for relationships (one-to-one, one-to-many, many-to-many). Regular scalar fields, JSON fields, and other non-relational columns are automatically included in the query result and do not need to be specified in the `include` object.

Applied to files:

apps/web/app/(ee)/api/cron/payouts/process/process-payouts.ts

🔇 Additional comments (3)

apps/web/app/(ee)/api/cron/payouts/process/process-payouts.ts (3)

11-11: LGTM: Import change aligns with new email flow.

The switch from batch email queuing to direct sendEmail calls is correctly reflected in the imports.

258-260: LGTM: Where clause correctly filters to initiating user.

The addition of the where: { userId } filter ensures that only the user who initiated the payout is retrieved, which aligns perfectly with the PR objective.

292-310: Email sending implementation looks good (contingent on fixing line 291).

The direct sendEmail call with the React template is correctly implemented. The email properties and template props are appropriate, and the logging provides useful debugging information.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4512e06 and ad6ee04.

📒 Files selected for processing (1)

apps/web/app/(ee)/api/cron/payouts/process/process-payouts.ts (4 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-10-28T19:17:44.390Z

Learnt from: TWilson023
Repo: dubinc/dub PR: 2985
File: apps/web/app/(ee)/api/network/programs/[programSlug]/route.ts:32-37
Timestamp: 2025-10-28T19:17:44.390Z
Learning: In Prisma queries, the `include` clause is only used for relationships (one-to-one, one-to-many, many-to-many). Regular scalar fields, JSON fields, and other non-relational columns are automatically included in the query result and do not need to be specified in the `include` object.

Applied to files:

apps/web/app/(ee)/api/cron/payouts/process/process-payouts.ts

🧬 Code graph analysis (1)

apps/web/app/(ee)/api/cron/payouts/process/process-payouts.ts (3)

packages/email/src/index.ts (1)

sendEmail (6-29)

packages/utils/src/functions/currency-formatter.ts (1)

currencyFormatter (7-22)

packages/email/src/templates/program-payout-thank-you.tsx (1)

ProgramPayoutThankYou (17-120)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: build

🔇 Additional comments (3)

apps/web/app/(ee)/api/cron/payouts/process/process-payouts.ts (3)

11-12: LGTM! Import changes align with individual email sending.

The switch from queueBatchEmail to sendEmail and the addition of the ProgramPayoutThankYou template import are correct and consistent with the refactored email logic below.

258-260: Good filtering to isolate the initiating user.

The where: { userId } clause correctly filters the users relation to include only the user who initiated the payout, which aligns with the PR objective.

292-310: Email sending logic looks correct.

The email is properly constructed with the ProgramPayoutThankYou React template and all required props. The console logging will help with debugging. This implementation correctly sends to only the user who initiated the payout as intended by the PR objective.

Note: This depends on fixing the critical bug on line 291.

apps/web/app/(ee)/api/cron/payouts/process/process-payouts.ts

Only send ProgramPayoutThankYou to userWhoInitiatedPayout

ad6ee04

coderabbitai bot reviewed Nov 22, 2025

View reviewed changes

apps/web/app/(ee)/api/cron/payouts/process/process-payouts.ts Show resolved Hide resolved

vercel bot deployed to Preview November 22, 2025 04:22 View deployment

steven-tey merged commit f470644 into main Nov 22, 2025
8 of 9 checks passed

steven-tey deleted the improve-payout-thank-you branch November 22, 2025 06:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Only send ProgramPayoutThankYou to userWhoInitiatedPayout #3145

Only send ProgramPayoutThankYou to userWhoInitiatedPayout #3145

Uh oh!

steven-tey commented Nov 22, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Nov 22, 2025 •

edited

Loading

Uh oh!

steven-tey commented Nov 22, 2025

Uh oh!

coderabbitai bot commented Nov 22, 2025

Uh oh!

coderabbitai bot commented Nov 22, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Only send ProgramPayoutThankYou to userWhoInitiatedPayout #3145

Only send ProgramPayoutThankYou to userWhoInitiatedPayout #3145

Uh oh!

Conversation

steven-tey commented Nov 22, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

vercel bot commented Nov 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

steven-tey commented Nov 22, 2025

Uh oh!

coderabbitai bot commented Nov 22, 2025

Uh oh!

coderabbitai bot commented Nov 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

steven-tey commented Nov 22, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Nov 22, 2025 •

edited

Loading

coderabbitai bot commented Nov 22, 2025 •

edited

Loading