Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix payout minimum amount display #3142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
steven-tey merged 1 commit into from
Nov 21, 2025
Merged

Fix payout minimum amount display #3142

steven-tey merged 1 commit into from
Nov 21, 2025

Conversation

@devkiran
Copy link
Collaborator

@devkiran devkiran commented Nov 21, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Bug Fixes
    • Fixed incorrect minimum payout amount display in the payout information tooltip. The value now displays accurately without improper unit conversion.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link
Contributor

vercel bot commented Nov 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
dub Ready Ready Preview Nov 21, 2025 2:12pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 21, 2025 •
edited
Loading

Walkthrough

The payout table tooltip in the dashboard now displays the minimum payout amount without division. The AmountRowItem component's tooltip title changed from showing minPayoutAmount / 100 to minPayoutAmount, altering the displayed threshold value.

Changes

Cohort / File(s) Change Summary
Payout Display
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/payouts/payout-table.tsx		 Modified tooltip title to display raw minPayoutAmount instead of minPayoutAmount / 100, changing the unit/scale shown for program minimum payout threshold

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Verify the value change is intentional and matches the new unit representation
  • Confirm no other tooltip or display logic requires similar adjustments

Possibly related PRs

Suggested reviewers

  • steven-tey

Poem

🐰 A tiny hop, a shift so slight,
The numbers shown now feel more right,
No division here, just truth displayed,
One small change, one fix well-made! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix payout minimum amount display' clearly and concisely describes the main change: correcting how the minimum payout amount is displayed in the tooltip.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-payout-currency
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 53ef322 and e414c09.

📒 Files selected for processing (1)
  • apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/payouts/payout-table.tsx (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings 
Learnt from: steven-tey
Repo: dubinc/dub PR: 0
File: :0-0
Timestamp: 2025-06-25T21:20:59.837Z
Learning: In the Dub codebase, payout limit validation uses a two-stage pattern: server actions perform quick sanity checks (payoutsUsage > payoutsLimit) for immediate user feedback, while the cron job (/cron/payouts) performs authoritative validation (payoutsUsage + payoutAmount > payoutsLimit) with actual calculated amounts before processing. This design provides fast user feedback while ensuring accurate limit enforcement at transaction time.
📚 Learning: 2025-10-15T01:05:43.266Z 
Learnt from: steven-tey
Repo: dubinc/dub PR: 2958
File: apps/web/app/app.dub.co/(dashboard)/[slug]/settings/members/page-client.tsx:432-457
Timestamp: 2025-10-15T01:05:43.266Z
Learning: In apps/web/app/app.dub.co/(dashboard)/[slug]/settings/members/page-client.tsx, defer refactoring the custom MenuItem component (lines 432-457) to use the shared dub/ui MenuItem component to a future PR, as requested by steven-tey.

Applied to files:

  • apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/payouts/payout-table.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
🔇 Additional comments (1)
apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/payouts/payout-table.tsx (1)

339-341: Verify that currencyFormatter handles cent-to-dollar conversion internally.

The fix ensures consistency—minPayoutAmount is now formatted the same way as payout.amount (line 331), and the direct comparison at line 334 confirms both values are in the same unit. However, this is critical: if currencyFormatter does not internally divide by 100, this change would display amounts incorrectly.

Run the following script to verify the implementation and usage patterns:

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@devkiran devkiran requested a review from steven-tey November 21, 2025 14:09
@steven-tey steven-tey merged commit bc6d144 into main Nov 21, 2025
7 of 8 checks passed
@steven-tey steven-tey deleted the fix-payout-currency branch November 21, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steven-tey steven-tey steven-tey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devkiran @steven-tey