fix: new pnl endpoint #1937
fix: new pnl endpoint #1937
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| const [daily, hourly] = await Promise.all([dailyResults, hourlyResults]); | ||
| return orderBy([...daily, ...hourly], [(p) => p.createdAtMilliseconds], ['asc']); |
There was a problem hiding this comment.
qq: how come we combine daily + hourly responses into a single array?
There was a problem hiding this comment.
it's basically the same thing we do for megavault pnl - it means the most recent end of the line is high resolution and the further from now you go you get lower res. I know it doesn't look perfect but I find it is an elegant solution and looks okay.
| const [daily, hourly] = await Promise.all([dailyResults, hourlyResults]); | ||
| return orderBy([...daily, ...hourly], [(p) => p.createdAtMilliseconds], ['asc']); |
There was a problem hiding this comment.
it's basically the same thing we do for megavault pnl - it means the most recent end of the line is high resolution and the further from now you go you get lower res. I know it doesn't look perfect but I find it is an elegant solution and looks okay.
| }, 'parentSubaccountHistoricalPnls'), | ||
| const [daily, hourly] = await Promise.all([dailyResults, hourlyResults]); | ||
| return orderBy([...daily, ...hourly], [(p) => p.createdAtMilliseconds], ['asc']); | ||
| }, 'parentSubaccountHistoricalPnlsV2'), |
|
gonna hold off on deploying while david makes sure this endpoint isn't totally broken |
Should be much faster now