Remove trailing slash from $SRCDIR and check for required env vars #1483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-lawrence
requested changes
Oct 28, 2025
There was a problem hiding this comment.
LOL, I've stubbed my toe on this many times when using tab completion to fill out the SRCDIR path, but never bothered to fix it.
Nit 1 - same as the other PR, if you can format the commit msg like a kernel commit. That is, a subject format "subsys/section: summary ...", the description, finished by your signed-off-by line.
Nit 2 - completely up to you, but would realpath be any more useful? I think it may solve this problem and also do some additional cleanup. I'd be happy either way and just wanted to mention it.
…base_patches` A trailing slash in $SRCDIR breaks the backup `cp` command by placing the ".orig" copy inside $SRCDIR instead of alongside it. This causes the subsequent diff to fail. Fix this by using `realpath` to canonicalize $SRCDIR. Additionally, add checks for required $SRCDIR, $ID, and $VERSION_ID env vars. Signed-off-by: Pablo Alessandro Santos Hugen <[email protected]>
4e28363 to
f2f16c8
Compare
joe-lawrence
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If $SRCDIR has a trailing slash (e.g.,
kernel/), the commandcp -r "$SRCDIR" "${SRCDIR}.orig"incorrectly copies the backup inside the source directory instead of alongside it. This causes the subsequentdiff -Nuprto fail or compute an incorrect diff.Also checks for the definitions of required env vars.