Gbrt for several scatter plots #133
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
reviewed
Dec 12, 2019
Comment on lines
+134
to
+139
| predictions = [] | ||
| for predictor in best_predictors: | ||
| predictions.append(predictor.predict(this_X)) | ||
| predictions = np.c_[predictions].T | ||
|
|
||
| y_pred_train += predictions |
Collaborator
There was a problem hiding this comment.
looks like you're already doing this above
Collaborator
Author
There was a problem hiding this comment.
I don't store them for all pairs though, so I'm recomputing for the optimum pair. I could also just store them all and select the optimum which might be more obvious?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @NicolasHug