configure toolchains with toolchain customization #11480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kpenfound <[email protected]>
Contributor
|
@kpenfound looks good, I would just call the field Also, thinking ahead, will this allow us to also disable checks like we were discussing separately? The only tricky part I see is that |
Signed-off-by: kpenfound <[email protected]>
Contributor
Author
|
@shykes yeah i was considering |
Signed-off-by: kpenfound <[email protected]>
Signed-off-by: kpenfound <[email protected]>
Signed-off-by: kpenfound <[email protected]>
Signed-off-by: kpenfound <[email protected]>
Signed-off-by: kpenfound <[email protected]>
shykes
approved these changes
Nov 25, 2025
raykao
pushed a commit
to raykao/dagger
that referenced
this pull request
Dec 9, 2025
* configure toolchains with toolchain customization Signed-off-by: kpenfound <[email protected]> * generate docs schema Signed-off-by: kpenfound <[email protected]> * plural customizations Signed-off-by: kpenfound <[email protected]> * keep old config keys for backwards compat Signed-off-by: kpenfound <[email protected]> * generate docs schema Signed-off-by: kpenfound <[email protected]> * preserve arguments and customizations in dagger develop Signed-off-by: kpenfound <[email protected]> * allow deprecated config.Arguments Signed-off-by: kpenfound <[email protected]> --------- Signed-off-by: kpenfound <[email protected]>
raykao
pushed a commit
to raykao/dagger
that referenced
this pull request
Dec 14, 2025
* configure toolchains with toolchain customization Signed-off-by: kpenfound <[email protected]> * generate docs schema Signed-off-by: kpenfound <[email protected]> * plural customizations Signed-off-by: kpenfound <[email protected]> * keep old config keys for backwards compat Signed-off-by: kpenfound <[email protected]> * generate docs schema Signed-off-by: kpenfound <[email protected]> * preserve arguments and customizations in dagger develop Signed-off-by: kpenfound <[email protected]> * allow deprecated config.Arguments Signed-off-by: kpenfound <[email protected]> --------- Signed-off-by: kpenfound <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #11373
New schema:
{ "name": "app", "engineVersion": "v0.19.4", "toolchains": [ { "name": "hello", "source": "../hello", "customization": [ { "function": ["configurableMessage"], "argument": "message", "default": "hola" } ] } ] }Old schema:
{ "name": "app", "engineVersion": "v0.19.4", "toolchains": [ { "name": "hello", "source": "../hello", "arguments": [ { "function": ["configurableMessage"], "name": "message", "default": "hola" } ] } ] }