chore: Email attachment testcase (Fixes #812) #814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3b45cd to
99f9cd3
Compare
99f9cd3 to
ec8c986
Compare
|
@yohamta All lint tests now work correctly! |
yottahmd
approved these changes
Feb 10, 2025
|
Looking good to me! Thanks for implementing the attachment functionality and updating the document! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #814 +/- ##
==========================================
- Coverage 56.06% 55.93% -0.14%
==========================================
Files 73 73
Lines 7921 7920 -1
==========================================
- Hits 4441 4430 -11
- Misses 3102 3110 +8
- Partials 378 380 +2
... and 16 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surface email attachments feature in mail executor and update docs.