Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[#992] feat: implement queue configuration #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 9, 2025
Merged

[#992] feat: implement queue configuration #1001

merged 5 commits into from
Jun 9, 2025

Conversation

@yottahmd
Copy link
Collaborator

@yottahmd yottahmd commented Jun 9, 2025 •
edited
Loading

Resolves #992

Overview:

  • Added global queue config settings

    queues:
  enabled: true # default is true
  config:
    - name: some_queue
      maxActiveRuns: 3

  • Added queue field as a DAG level field

    queue: global-queue
maxActiveRuns: 3

    You can set it in the base DAG file to use same queue across all DAGs.

  • Fixed a bug: default value (1) was not set for maxActiveRuns in DAG loading process

@yottahmd yottahmd merged commit de9d6d2 into main Jun 9, 2025
4 checks passed
@yottahmd yottahmd deleted the 992-queue-config branch June 9, 2025 15:36
@codecov
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

Attention: Patch coverage is 56.62651% with 36 lines in your changes missing coverage. Please review.

Project coverage is 61.66%. Comparing base (557fc2f) to head (42c1876).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/scheduler/scheduler.go 34.78% 28 Missing and 2 partials ⚠️
internal/cmd/dequeue.go 25.00% 2 Missing and 1 partial ⚠️
internal/cmd/enqueue.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1001      +/-   ##
==========================================
+ Coverage   61.65%   61.66%   +0.01%     
==========================================
  Files          89       89              
  Lines       12356    12408      +52     
==========================================
+ Hits         7618     7652      +34     
- Misses       3991     4008      +17     
- Partials      747      748       +1
Files with missing lines Coverage Δ
internal/config/config.go 76.74% <ø> (ø)
internal/config/loader.go 90.69% <100.00%> (+0.37%) ⬆️
internal/digraph/builder.go 65.26% <100.00%> (+0.27%) ⬆️
internal/digraph/dag.go 71.52% <100.00%> (+0.57%) ⬆️
internal/cmd/dequeue.go 50.00% <25.00%> (-1.57%) ⬇️
internal/cmd/enqueue.go 62.06% <25.00%> (-1.79%) ⬇️
internal/scheduler/scheduler.go 48.36% <34.78%> (-3.01%) ⬇️

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 557fc2f...42c1876. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: flexible queue control

1 participant

@yottahmd