fix(docker): container initialization bug with registryAuths field
#1330
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a container initialization bug related to the registryAuths field and updates the JSON schema to include this missing field.
- Adds comprehensive
registryAuthsfield definition to the DAG schema - Fixes context key type definitions to use proper struct types instead of type aliases
- Updates container client initialization to include the
authManagerfield
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| schemas/dag.schema.json | Adds complete registryAuths field schema with flexible authentication options |
| internal/runtime/builtin/ssh/ssh.go | Fixes context key type definition for SSH client |
| internal/runtime/builtin/docker/executor.go | Fixes context key types and renames function for consistency |
| internal/runtime/builtin/docker/client.go | Adds missing authManager field to client initialization and clears entrypoint when command is set |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
registryAuths fieldregistryAuths field
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1330 +/- ##
==========================================
- Coverage 60.81% 60.75% -0.07%
==========================================
Files 159 159
Lines 22814 22822 +8
==========================================
- Hits 13874 13865 -9
- Misses 7816 7833 +17
Partials 1124 1124
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Description
registryAuthsfield was present.registryAuthsfield.Related Issue
#1327 and #1261
Checklist
Before submitting this PR, please ensure:
make test)make lint)Additional Notes