fix(runtime): include queue name in dequeue command #1481
Conversation
The SubCmdBuilder.Dequeue method was missing the queue name parameter when building the dequeue command. The CLI command expects the queue name as the first positional argument after "dequeue", but it was not being included, causing dequeue operations via the API to fail. This change: - Updates Dequeue to use dag.ProcGroup() to get the queue name - Includes the queue name as the first argument after "dequeue" - Updates tests to verify the queue name is included - Adds test case for DAGs with custom queue names Fixes the issue where dequeuing from the API failed because the queue name was not being passed to the CLI command.
WalkthroughThe Dequeue command construction is updated to utilize the DAG object parameter (previously unused) and incorporate the queue name from the DAG as a second CLI argument. The control flow shifts from a two-argument form (command, dag-run) to a three-argument form (command, queue-name, dag-run), with tests updated to verify the queue name derivation from DAG.Queue or DAG name as fallback. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
|
Also check if the dag run is assigned to default queue. Do regression testing for default case via api route |
yottahmd
left a comment
There was a problem hiding this comment.
Thank you very much, LGTM! 🚀🚀🚀
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1481 +/- ##
==========================================
+ Coverage 59.91% 59.93% +0.01%
==========================================
Files 195 195
Lines 21886 21887 +1
==========================================
+ Hits 13114 13117 +3
Misses 7364 7364
+ Partials 1408 1406 -2
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
The SubCmdBuilder.Dequeue method was missing the queue name parameter when building the dequeue command. The CLI command expects the queue name as the first positional argument after "dequeue", but it was not being included, causing dequeue operations via the API to fail.
This change:
Fixes the issue where dequeuing from the API failed because the queue name was not being passed to the CLI command.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.