support for time.Time, refactoring selection api method names + example app updates #81
Conversation
| import "fmt" | ||
| import "github.com/dadleyy/marlow/examples/library/models" | ||
|
|
||
| func Browse(store *models.Stores, args []string) error { |
There was a problem hiding this comment.
exported function Browse should have comment or be unexported
|
|
||
| import "github.com/dadleyy/marlow/examples/library/models" | ||
|
|
||
| type Command func(*models.Stores, []string) error |
There was a problem hiding this comment.
exported type Command should have comment or be unexported
| Imports importModelList `json:"imports"` | ||
| } | ||
|
|
||
| func Import(stores *models.Stores, args []string) error { |
There was a problem hiding this comment.
exported function Import should have comment or be unexported
|
|
||
| // marlow:ignore | ||
|
|
||
| type Stores struct { |
There was a problem hiding this comment.
exported type Stores should have comment or be unexported
| } | ||
| } | ||
|
|
||
| func (db *DatabaseConnections) Close() error { |
There was a problem hiding this comment.
exported method DatabaseConnections.Close should have comment or be unexported
| return nil | ||
| } | ||
|
|
||
| func (db *DatabaseConnections) Stores(logger io.Writer) *Stores { |
There was a problem hiding this comment.
exported method DatabaseConnections.Stores should have comment or be unexported
| sqlite *sql.DB | ||
| } | ||
|
|
||
| func (db *DatabaseConnections) Initialize() error { |
There was a problem hiding this comment.
exported method DatabaseConnections.Initialize should have comment or be unexported
| psqlConnectionString = "user=%s dbname=%s port=%s sslmode=disable password=%s" | ||
| ) | ||
|
|
||
| type DatabaseConnections struct { |
There was a problem hiding this comment.
exported type DatabaseConnections should have comment or be unexported
| import "io" | ||
| import "fmt" | ||
| import "database/sql" | ||
| import _ "github.com/lib/pq" |
There was a problem hiding this comment.
a blank import should be only in a main or test package, or have a comment justifying it
|
|
||
| // marlow:ignore | ||
|
|
||
| type DatabaseConfig struct { |
There was a problem hiding this comment.
exported type DatabaseConfig should have comment or be unexported
Notable changes
f3c65d0time.Timefields351439bSelectmethods to include record nameeb6a8d05acca17f406cd3example-cleanup