Refactor successful login detection #62
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es returned changed this to require a minimum of 27 bytes (size of loginReply struct) and checked for a non-blank Key as Key is only returned after a successful logon. Replaced Foo? with WorldStream : just so logging to console was a bit clearer
…ne easier to step-into.
…nerated xPackets.cs files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of looking at number of bytes returned changed this to require a minimum of 27 bytes (size of loginReply struct) and checked for a non-blank Key as Key is only returned after a successful logon.
Replaced Foo? with WorldStream : just so logging to console was a bit clearer