Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

Adds a context menu to the thumbtable to allow pinning any image in the 2nd darkroom window#20398

Open
masterpiga wants to merge 1 commit intodarktable-org:masterfrom
masterpiga:2nd_win
Open

Adds a context menu to the thumbtable to allow pinning any image in the 2nd darkroom window#20398
masterpiga wants to merge 1 commit intodarktable-org:masterfrom
masterpiga:2nd_win

Conversation

@masterpiga
Copy link
Contributor

This adds the ability to pin an image directly from the thumbtable, which makes it possible to show different images in the 2nd window while keeping the same image in the main window.

It adds a context menu to the images in the thumbtable, which for the moment contains only this one action.

It also fixes a bug that may cause darktable to crash when the 2nd window is toggled off and on very quickly, which may try to recreate the window while the previous one has not finished clearing up yet.

@TurboGit This is another follow up to #19963.

pinning any image in the 2nd darkroom window.
@TurboGit
Copy link
Member

@masterpiga : I'm not sure about this one because it introduces for the first time a contextual menu on the lighttable and why pin an image on the lighttable while the second window is actionable only on the darkroom.

@wpferguson
Copy link
Member

My first thought was this would be like Pandora's box mating with Frankenstein.

My thoughts about why we shouldn't

  • shortcut is much faster and almost no code. A menu requires a click to open, then reading until the correct item is found, then clicking again and all of the code to support that.
  • we can also use actions on selected image(s)
  • if we have a context menu, then whatever keystroke is used to trigger it is lost as a shortcut (unless the menu is shortcut enabled)
  • more work for the translators
  • some translations may not work well with a menu (i.e. the problem we just had with Italian translations)
  • if we open this door, then the next one will be in darkroom
  • we will get bombarded with feature requests to add whatever to the context menu (see above mating reference)
  • we have to support it, not just the code but the user expectations ("the menu should work like this and not like that...")
  • it's one more thing we'll have to port to GTK 4
  • if we decide to merge we need to come up with a standard spelling out what's acceptable in the menu and what's not (and stick to it). Preferably before we merge so that we're ready for the storm. My expectation is users will want to run darktable almost entirely (or as much as possible) from the right click menu.

All of the above is just quickly off the top of my head.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants