Conversation
srawlins
approved these changes
Feb 22, 2024
Member
srawlins
left a comment
There was a problem hiding this comment.
Very nice! Nice test refactoring.
Member
I think I would be in favor of this. I can see supporting one of two designs:
|
Member
Author
|
I'll look into it in my free-time, but if we could, I think maybe it'd be good to display what's in the source code. I'll make an issue for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added generic type parameters to function parameters, fixing #3452.
For that issue's example, it'd show as the following now.
@srawlins
Wondering if we should revisit the function format and make it
Object? Function<T>() extractinstead ofObject? extract<T>()? This CL isn't for that, but it wouldn't be too hard to make that change.parameter_test.dartbecause I was itching to do so.test_formalParameter_generic_methodandtest_formalParameter_generic_topLevelFunction.Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.