This repository was archived by the owner on Sep 13, 2021. It is now read-only.
Add header id #28
Merged
Add header id #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok with me. we will at some point change all these selectors to classes, and also make sure they are only searched within the chart parent element. but we don't have to do it now |
gka
approved these changes
Apr 27, 2020
|
Ok thanks, I'll merge this now. I don't mind going through the visualizations and changing relevant selectors to target But in the future we can still get rid of the ids (also in footer etc). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have several visualization types that rely on chart header (
div.dw-chart-header) having an id value ofheader. From what I can see, it gets used at least inlocator-maps,visualization-columns-chartsandvisualization-pie-chart.This PR adds the ability to add id to
BlockRegionand adds the idheaderto chart header.