Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@stolarczyk
Copy link
Member

@stolarczyk stolarczyk commented Feb 25, 2021

adds jsoschema validation

todo:

  • changelog
  • tests
  • docs
  • version

@stolarczyk stolarczyk mentioned this pull request Feb 25, 2021
5 tasks
@stolarczyk stolarczyk linked an issue Feb 25, 2021 that may be closed by this pull request
This was referenced Feb 26, 2021
@codecov-io
Copy link

codecov-io commented Mar 4, 2021

Codecov Report

Merging #44 (41e049a) into master (735bd43) will increase coverage by 5.88%.
The diff coverage is 89.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   84.25%   90.13%   +5.88%     
==========================================
  Files          10        9       -1     
  Lines         635      730      +95     
==========================================
+ Hits          535      658     +123     
+ Misses        100       72      -28     
Impacted Files Coverage Δ
yacman/alias.py 83.33% <82.60%> (+12.12%) ⬆️
yacman/yacman.py 80.35% <83.58%> (+0.03%) ⬆️
tests/test_yacman_alias.py 97.63% <93.87%> (-2.37%) ⬇️
tests/conftest.py 100.00% <100.00%> (ø)
tests/test_yacman.py 98.98% <100.00%> (+0.67%) ⬆️
yacman/_version.py 100.00% <100.00%> (ø)
yacman/const.py 100.00% <100.00%> (ø)
setup.py
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 735bd43...41e049a. Read the comment docs.

@stolarczyk stolarczyk linked an issue Mar 4, 2021 that may be closed by this pull request
@stolarczyk stolarczyk linked an issue Mar 5, 2021 that may be closed by this pull request
@stolarczyk stolarczyk merged commit 4adf575 into master Mar 10, 2021
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 89.94413% with 18 lines in your changes missing coverage. Please review.

Project coverage is 90.13%. Comparing base (735bd43) to head (41e049a).
Report is 120 commits behind head on master.

Files Patch % Lines
yacman/yacman.py 83.58% 11 Missing ⚠️
yacman/alias.py 82.60% 4 Missing ⚠️
tests/test_yacman_alias.py 93.87% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   84.25%   90.13%   +5.88%     
==========================================
  Files          10        9       -1     
  Lines         635      730      +95     
==========================================
+ Hits          535      658     +123     
+ Misses        100       72      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

yacman dev breaks bulker optional jsonschema validation collections warning

4 participants