-
Notifications
You must be signed in to change notification settings - Fork 3.3k
feat(openapi-v3): Support filter object in scroll API #14524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(openapi-v3): Support filter object in scroll API #14524
Conversation
Bundle ReportChanges will decrease total bundle size by 745 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
9fd44ef to
50d77d6
Compare
david-leifker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A few minor tweaks and open question about the implementation around a new vs existing endpoint.
...dels/src/main/java/io/datahubproject/openapi/v3/models/GenericEntityScrollRequestBodyV3.java
Outdated
Show resolved
Hide resolved
...i-servlet/models/src/main/java/io/datahubproject/openapi/v3/models/ConjunctiveCriterion.java
Show resolved
Hide resolved
...napi-servlet/src/test/java/io/datahubproject/openapi/v3/controller/EntityControllerTest.java
Show resolved
Hide resolved
...a-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v3/OpenAPIV3Generator.java
Show resolved
Hide resolved
.../openapi-servlet/src/main/java/io/datahubproject/openapi/v3/controller/EntityController.java
Outdated
Show resolved
Hide resolved
c75d900 to
2f21fbe
Compare
...a-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v3/OpenAPIV3Generator.java
Outdated
Show resolved
Hide resolved
...a-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v3/OpenAPIV3Generator.java
Outdated
Show resolved
Hide resolved
...a-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v3/OpenAPIV3Generator.java
Outdated
Show resolved
Hide resolved
...a-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v3/OpenAPIV3Generator.java
Outdated
Show resolved
Hide resolved
...a-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v3/OpenAPIV3Generator.java
Outdated
Show resolved
Hide resolved
...a-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v3/OpenAPIV3Generator.java
Outdated
Show resolved
Hide resolved
.../openapi-servlet/src/main/java/io/datahubproject/openapi/v3/controller/EntityController.java
Outdated
Show resolved
Hide resolved
| Schema conjunctive = | ||
| newSchema() | ||
| .type(TYPE_OBJECT) | ||
| .description("A group of criteria ANDed together.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate the documentation details here. Thanks!
f651cf6 to
a5a29ac
Compare
|
Thank you! |
Summary
This PR adds explicit filter support in /scroll API OpenAPI v3. It has similar interface as its counterparts in RestLi
ACTION_SCROLL_ACROSS_ENTITIESand GraphQLquery scrollAcrossEntities.Test
Locally deployed and tested new API with curl request.
Swagger UI
