improvement(summary-tab): hide current property in replace dropdown of property header #14842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle ReportChanges will increase total bundle size by 382 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
chriscollins3456
approved these changes
Oct 7, 2025
Comment on lines
87
to
+89
| const menuItems = usePropertyMenuItems(position, property.type); | ||
|
|
||
| const filteredItems = filterCurrentItemInReplaceMenu(menuItems, property); |
Collaborator
There was a problem hiding this comment.
i wonder if userPropertyMenuItems could handle this filtering logic for us instead of in this component here? if so that could be a nice followup
yoonhyejin
pushed a commit
that referenced
this pull request
Oct 9, 2025
…f property header (#14842)
alplatonov
pushed a commit
to alplatonov/datahub
that referenced
this pull request
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear ticket:
https://linear.app/acryl-data/issue/CH-758/hide-current-property-in-dropdown-for-replace-in-summary-elements
Description:
This hides the current property that is clicked from the replace menu items in properties header on the asset summary tab.
It gives a better experience to the user as giving an option to replace a property with the same one doesn't make much sense.
Screenshots: