Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(ingest/grafana): add exception handling #14921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anshbansal merged 2 commits into from
Oct 3, 2025
Merged

fix(ingest/grafana): add exception handling #14921

anshbansal merged 2 commits into from
Oct 3, 2025

Conversation

@anshbansal
Copy link
Collaborator

@anshbansal anshbansal commented Oct 3, 2025

In case title of panel is missing we started getting

Fri Oct  3 18:16:12 IST 2025	 panels.append(Panel.parse_obj(panel_data))
Fri Oct  3 18:16:12 IST 2025	 ^^^^^^^^^^^^^^^^^^^^^^^^^^^
Fri Oct  3 18:16:12 IST 2025	 File "pydantic/main.py", line 532, in pydantic.main.BaseModel.parse_obj
Fri Oct  3 18:16:12 IST 2025	 File "pydantic/main.py", line 347, in pydantic.main.BaseModel.__init__
Fri Oct  3 18:16:12 IST 2025	 pydantic.error_wrappers.ValidationError: 1 validation error for Panel
Fri Oct  3 18:16:12 IST 2025	 title
Fri Oct  3 18:16:12 IST 2025	 field required (type=value_error.missing)

which caused the whole ingestion to start failing.

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 3, 2025
@codecov
Copy link

codecov bot commented Oct 3, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ion/src/datahub/ingestion/source/grafana/models.py 71.42% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (71.42%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Oct 3, 2025
@acrylJonny acrylJonny self-requested a review October 3, 2025 13:12
acrylJonny
acrylJonny approved these changes Oct 3, 2025
View reviewed changes
Copy link
Collaborator

@acrylJonny acrylJonny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Oct 3, 2025
@anshbansal anshbansal merged commit 1d0e377 into master Oct 3, 2025
69 of 71 checks passed
@anshbansal anshbansal deleted the ab-2025-oct-03-add-exception-handling branch October 3, 2025 15:01
RyanHolstien pushed a commit that referenced this pull request Oct 6, 2025
@anshbansal @RyanHolstien
fix(ingest/grafana): add exception handling (#14921)
eec5c45
yoonhyejin pushed a commit that referenced this pull request Oct 9, 2025
@anshbansal @yoonhyejin
fix(ingest/grafana): add exception handling (#14921)
dbcf984
alplatonov pushed a commit to alplatonov/datahub that referenced this pull request Oct 13, 2025
@anshbansal @alplatonov
fix(ingest/grafana): add exception handling (datahub-project#14921)
dae1a32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sgomezvillamor sgomezvillamor sgomezvillamor approved these changes

@acrylJonny acrylJonny acrylJonny approved these changes

Assignees

No one assigned

Labels

ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anshbansal @sgomezvillamor @acrylJonny