fix(snowflake): correct additional_database_names OR logic in access_history filter #14104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add push_down_database_pattern_access_history and additional_database_names_allowlist config fields to SnowflakeV2Config to match SnowflakeQueriesExtractorConfig. These fields were added to SnowflakeQueriesExtractorConfig in PR #14021 but were missing from the main SnowflakeV2Config, causing the fields to always use their default values. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…history filter 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…942/fix-snowflake-additional_database_names
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
…rings 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…942/fix-snowflake-additional_database_names
treff7es
approved these changes
Jul 16, 2025
sgomezvillamor
added a commit
that referenced
this pull request
Jul 16, 2025
…history filter (#14104) Co-authored-by: Claude <[email protected]>
kartikey-visa
pushed a commit
to kartikey-visa/datahub
that referenced
this pull request
Jul 23, 2025
…history filter (datahub-project#14104) Co-authored-by: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the logic bug in
_build_access_history_database_filter_conditionwhereadditional_database_nameswas being AND'ed with database patterns instead of OR'edTest plan
🤖 Generated with Claude Code