Switch Raman block to use renishawWire package
#1218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e8d3fd7 to
3ac602e
Compare
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
ml-evs/switch-to-py-wdf-reader
|
| Run status |
|
| Run duration | 07m 18s |
| Commit |
|
| Committer | Matthew Evans |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
504
|
| View all changes introduced in this branch ↗︎ | |
3fc0e4a to
d1bfbb1
Compare
d1bfbb1 to
59c8654
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1218 +/- ##
==========================================
+ Coverage 71.58% 71.64% +0.06%
==========================================
Files 66 66
Lines 4469 4468 -1
==========================================
+ Hits 3199 3201 +2
+ Misses 1270 1267 -3
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rosettasciio's licensing is still up for discussion (hyperspy/rosettasciio#51). To be on the safe side of GPL wrt. whether including it as a dependency constitutes "linking" or "aggregation" on the Python side, let's defer back to the original MIT licensed package that the Rosetta version is based on.
This seems to work fine for 1D spectra at least, though might need to put in some work to extract offsets to ensure consistency, even if we're not entirely sure what these offsets entail.