Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@BenjaminCharmes
Copy link
Contributor

@BenjaminCharmes BenjaminCharmes commented Sep 12, 2025

Prevents DialogModal message text from overflowing.

  • Before:
Screenshot 2025-09-12 at 16 37 40
  • After:
Screenshot 2025-09-15 at 13 13 41

@codecov
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.06%. Comparing base (767e66d) to head (6bd8493).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1346   +/-   ##
=======================================
  Coverage   80.06%   80.06%           
=======================================
  Files          70       70           
  Lines        4731     4731           
=======================================
  Hits         3788     3788           
  Misses        943      943           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress
Copy link

cypress bot commented Sep 12, 2025

datalab    Run #3860

Run Properties:  status check passed Passed #3860  •  git commit cd23a50bee ℹ️: Merge f0db6ea7d36283c5140ced3523c57c94cc1af2bd into 986d3b3153b58a952cd2ecd7bfe3...
Project datalab
Branch Review bc/fix-dialogmodal
Run status status check passed Passed #3860
Run duration 07m 07s
Commit git commit cd23a50bee ℹ️: Merge f0db6ea7d36283c5140ced3523c57c94cc1af2bd into 986d3b3153b58a952cd2ecd7bfe3...
Committer Ben Charmes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 336
View all changes introduced in this branch ↗︎

@BenjaminCharmes BenjaminCharmes marked this pull request as ready for review September 15, 2025 11:14
@ml-evs ml-evs enabled auto-merge (squash) September 23, 2025 10:36
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ml-evs ml-evs merged commit d58aad2 into main Sep 23, 2025
15 checks passed
@ml-evs ml-evs deleted the bc/fix-dialogmodal branch September 23, 2025 10:47
be-smith pushed a commit that referenced this pull request Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants