fix(rrule): don't die on experimental properties #1374
+21
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These kind of properties are allowed by RFC 5545 and used in the wild for storing various non-standard information. One example is [how GNOME Evolution caches RRULE ends][1]. With this fix, we avoid failing unnecessarily on such RRULE. [1]: https://discourse.gnome.org/t/working-with-evolution-mail-and-web-calendar-using-rrule-fail-because-of-x-evolution-enddate-in-rrule/19710/3 @moduon MT-6287
Author
|
It seems failing CI was broken before this PR. |
arj-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Jul 18, 2024
If you created an event using GNOME Evolution/Calendar, it could add an `X-EVOLUTION-ENDDATE` parameter to the event's `RRULE`. When that happens, if the event is pushed to a Google Calendar and synced in Odoo, all participants' calendars stop syncing from there onwards. In https://discourse.gnome.org/t/working-with-evolution-mail-and-web-calendar-using-rrule-fail-because-of-x-evolution-enddate-in-rrule/19710/3 it explains why this happens and how it's actually a supported feature of RFC 5545. Dateutil doesn't support that feature. It just fails with `ValueError`. Progress is being tracked in dateutil/dateutil#1374. Regarding what matters to Odoo, we can just strip any X-named params from the RRULE prefix and live happy with the rest (or fail if there's really a wrongly-formatted RRULE param). This way we avoid dateutil to fail unnecessarily and unlock users Google calendars synchronizations. @moduon MT-6287
yajo
added a commit
to moduon/odoo
that referenced
this pull request
Jul 25, 2024
If you created an event using GNOME Evolution/Calendar, it could add an `X-EVOLUTION-ENDDATE` parameter to the event's `RRULE`. When that happens, if the event is pushed to a Google Calendar and synced in Odoo, all participants' calendars stop syncing from there onwards. In https://discourse.gnome.org/t/working-with-evolution-mail-and-web-calendar-using-rrule-fail-because-of-x-evolution-enddate-in-rrule/19710/3 it explains why this happens and how it's actually a supported feature of RFC 5545. Dateutil doesn't support that feature. It just fails with `ValueError`. Progress is being tracked in dateutil/dateutil#1374. Regarding what matters to Odoo, we can just strip any X-named params from the RRULE prefix and value, and live happy with the rest (or fail if there's really a wrongly-formatted RRULE param). This way we avoid dateutil to fail unnecessarily and unlock users Google calendars synchronizations. We now store the full RRULE string when syncing, to avoid losing those parameters, in case someone wants to use them in the future. @moduon MT-6287
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Sep 2, 2024
If you created an event using GNOME Evolution/Calendar, it could add an `X-EVOLUTION-ENDDATE` parameter to the event's `RRULE`. When that happens, if the event is pushed to a Google Calendar and synced in Odoo, all participants' calendars stop syncing from there onwards. In https://discourse.gnome.org/t/working-with-evolution-mail-and-web-calendar-using-rrule-fail-because-of-x-evolution-enddate-in-rrule/19710/3 it explains why this happens and how it's actually a supported feature of RFC 5545. Dateutil doesn't support that feature. It just fails with `ValueError`. Progress is being tracked in dateutil/dateutil#1374. Regarding what matters to Odoo, we can just strip any X-named params from the RRULE prefix and value, and live happy with the rest (or fail if there's really a wrongly-formatted RRULE param). This way we avoid dateutil to fail unnecessarily and unlock users Google calendars synchronizations. We now store the full RRULE string when syncing, to avoid losing those parameters, in case someone wants to use them in the future. @moduon MT-6287 closes #171784 Signed-off-by: Arnaud Joset (arj) <[email protected]>
fw-bot
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Sep 2, 2024
If you created an event using GNOME Evolution/Calendar, it could add an `X-EVOLUTION-ENDDATE` parameter to the event's `RRULE`. When that happens, if the event is pushed to a Google Calendar and synced in Odoo, all participants' calendars stop syncing from there onwards. In https://discourse.gnome.org/t/working-with-evolution-mail-and-web-calendar-using-rrule-fail-because-of-x-evolution-enddate-in-rrule/19710/3 it explains why this happens and how it's actually a supported feature of RFC 5545. Dateutil doesn't support that feature. It just fails with `ValueError`. Progress is being tracked in dateutil/dateutil#1374. Regarding what matters to Odoo, we can just strip any X-named params from the RRULE prefix and value, and live happy with the rest (or fail if there's really a wrongly-formatted RRULE param). This way we avoid dateutil to fail unnecessarily and unlock users Google calendars synchronizations. We now store the full RRULE string when syncing, to avoid losing those parameters, in case someone wants to use them in the future. @moduon MT-6287 X-original-commit: edb4eb7
fw-bot
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Sep 2, 2024
If you created an event using GNOME Evolution/Calendar, it could add an `X-EVOLUTION-ENDDATE` parameter to the event's `RRULE`. When that happens, if the event is pushed to a Google Calendar and synced in Odoo, all participants' calendars stop syncing from there onwards. In https://discourse.gnome.org/t/working-with-evolution-mail-and-web-calendar-using-rrule-fail-because-of-x-evolution-enddate-in-rrule/19710/3 it explains why this happens and how it's actually a supported feature of RFC 5545. Dateutil doesn't support that feature. It just fails with `ValueError`. Progress is being tracked in dateutil/dateutil#1374. Regarding what matters to Odoo, we can just strip any X-named params from the RRULE prefix and value, and live happy with the rest (or fail if there's really a wrongly-formatted RRULE param). This way we avoid dateutil to fail unnecessarily and unlock users Google calendars synchronizations. We now store the full RRULE string when syncing, to avoid losing those parameters, in case someone wants to use them in the future. @moduon MT-6287 X-original-commit: edb4eb7
fw-bot
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Sep 2, 2024
If you created an event using GNOME Evolution/Calendar, it could add an `X-EVOLUTION-ENDDATE` parameter to the event's `RRULE`. When that happens, if the event is pushed to a Google Calendar and synced in Odoo, all participants' calendars stop syncing from there onwards. In https://discourse.gnome.org/t/working-with-evolution-mail-and-web-calendar-using-rrule-fail-because-of-x-evolution-enddate-in-rrule/19710/3 it explains why this happens and how it's actually a supported feature of RFC 5545. Dateutil doesn't support that feature. It just fails with `ValueError`. Progress is being tracked in dateutil/dateutil#1374. Regarding what matters to Odoo, we can just strip any X-named params from the RRULE prefix and value, and live happy with the rest (or fail if there's really a wrongly-formatted RRULE param). This way we avoid dateutil to fail unnecessarily and unlock users Google calendars synchronizations. We now store the full RRULE string when syncing, to avoid losing those parameters, in case someone wants to use them in the future. @moduon MT-6287 X-original-commit: edb4eb7
fw-bot
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Sep 2, 2024
If you created an event using GNOME Evolution/Calendar, it could add an `X-EVOLUTION-ENDDATE` parameter to the event's `RRULE`. When that happens, if the event is pushed to a Google Calendar and synced in Odoo, all participants' calendars stop syncing from there onwards. In https://discourse.gnome.org/t/working-with-evolution-mail-and-web-calendar-using-rrule-fail-because-of-x-evolution-enddate-in-rrule/19710/3 it explains why this happens and how it's actually a supported feature of RFC 5545. Dateutil doesn't support that feature. It just fails with `ValueError`. Progress is being tracked in dateutil/dateutil#1374. Regarding what matters to Odoo, we can just strip any X-named params from the RRULE prefix and value, and live happy with the rest (or fail if there's really a wrongly-formatted RRULE param). This way we avoid dateutil to fail unnecessarily and unlock users Google calendars synchronizations. We now store the full RRULE string when syncing, to avoid losing those parameters, in case someone wants to use them in the future. @moduon MT-6287 X-original-commit: edb4eb7
fw-bot
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Sep 2, 2024
If you created an event using GNOME Evolution/Calendar, it could add an `X-EVOLUTION-ENDDATE` parameter to the event's `RRULE`. When that happens, if the event is pushed to a Google Calendar and synced in Odoo, all participants' calendars stop syncing from there onwards. In https://discourse.gnome.org/t/working-with-evolution-mail-and-web-calendar-using-rrule-fail-because-of-x-evolution-enddate-in-rrule/19710/3 it explains why this happens and how it's actually a supported feature of RFC 5545. Dateutil doesn't support that feature. It just fails with `ValueError`. Progress is being tracked in dateutil/dateutil#1374. Regarding what matters to Odoo, we can just strip any X-named params from the RRULE prefix and value, and live happy with the rest (or fail if there's really a wrongly-formatted RRULE param). This way we avoid dateutil to fail unnecessarily and unlock users Google calendars synchronizations. We now store the full RRULE string when syncing, to avoid losing those parameters, in case someone wants to use them in the future. @moduon MT-6287 X-original-commit: edb4eb7
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Sep 3, 2024
If you created an event using GNOME Evolution/Calendar, it could add an `X-EVOLUTION-ENDDATE` parameter to the event's `RRULE`. When that happens, if the event is pushed to a Google Calendar and synced in Odoo, all participants' calendars stop syncing from there onwards. In https://discourse.gnome.org/t/working-with-evolution-mail-and-web-calendar-using-rrule-fail-because-of-x-evolution-enddate-in-rrule/19710/3 it explains why this happens and how it's actually a supported feature of RFC 5545. Dateutil doesn't support that feature. It just fails with `ValueError`. Progress is being tracked in dateutil/dateutil#1374. Regarding what matters to Odoo, we can just strip any X-named params from the RRULE prefix and value, and live happy with the rest (or fail if there's really a wrongly-formatted RRULE param). This way we avoid dateutil to fail unnecessarily and unlock users Google calendars synchronizations. We now store the full RRULE string when syncing, to avoid losing those parameters, in case someone wants to use them in the future. @moduon MT-6287 closes #178862 X-original-commit: edb4eb7 Signed-off-by: Arnaud Joset (arj) <[email protected]>
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Sep 3, 2024
If you created an event using GNOME Evolution/Calendar, it could add an `X-EVOLUTION-ENDDATE` parameter to the event's `RRULE`. When that happens, if the event is pushed to a Google Calendar and synced in Odoo, all participants' calendars stop syncing from there onwards. In https://discourse.gnome.org/t/working-with-evolution-mail-and-web-calendar-using-rrule-fail-because-of-x-evolution-enddate-in-rrule/19710/3 it explains why this happens and how it's actually a supported feature of RFC 5545. Dateutil doesn't support that feature. It just fails with `ValueError`. Progress is being tracked in dateutil/dateutil#1374. Regarding what matters to Odoo, we can just strip any X-named params from the RRULE prefix and value, and live happy with the rest (or fail if there's really a wrongly-formatted RRULE param). This way we avoid dateutil to fail unnecessarily and unlock users Google calendars synchronizations. We now store the full RRULE string when syncing, to avoid losing those parameters, in case someone wants to use them in the future. @moduon MT-6287 closes #178833 X-original-commit: edb4eb7 Signed-off-by: Arnaud Joset (arj) <[email protected]>
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Sep 3, 2024
If you created an event using GNOME Evolution/Calendar, it could add an `X-EVOLUTION-ENDDATE` parameter to the event's `RRULE`. When that happens, if the event is pushed to a Google Calendar and synced in Odoo, all participants' calendars stop syncing from there onwards. In https://discourse.gnome.org/t/working-with-evolution-mail-and-web-calendar-using-rrule-fail-because-of-x-evolution-enddate-in-rrule/19710/3 it explains why this happens and how it's actually a supported feature of RFC 5545. Dateutil doesn't support that feature. It just fails with `ValueError`. Progress is being tracked in dateutil/dateutil#1374. Regarding what matters to Odoo, we can just strip any X-named params from the RRULE prefix and value, and live happy with the rest (or fail if there's really a wrongly-formatted RRULE param). This way we avoid dateutil to fail unnecessarily and unlock users Google calendars synchronizations. We now store the full RRULE string when syncing, to avoid losing those parameters, in case someone wants to use them in the future. @moduon MT-6287 closes #178814 X-original-commit: edb4eb7 Signed-off-by: Arnaud Joset (arj) <[email protected]>
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Sep 4, 2024
If you created an event using GNOME Evolution/Calendar, it could add an `X-EVOLUTION-ENDDATE` parameter to the event's `RRULE`. When that happens, if the event is pushed to a Google Calendar and synced in Odoo, all participants' calendars stop syncing from there onwards. In https://discourse.gnome.org/t/working-with-evolution-mail-and-web-calendar-using-rrule-fail-because-of-x-evolution-enddate-in-rrule/19710/3 it explains why this happens and how it's actually a supported feature of RFC 5545. Dateutil doesn't support that feature. It just fails with `ValueError`. Progress is being tracked in dateutil/dateutil#1374. Regarding what matters to Odoo, we can just strip any X-named params from the RRULE prefix and value, and live happy with the rest (or fail if there's really a wrongly-formatted RRULE param). This way we avoid dateutil to fail unnecessarily and unlock users Google calendars synchronizations. We now store the full RRULE string when syncing, to avoid losing those parameters, in case someone wants to use them in the future. @moduon MT-6287 closes #178872 X-original-commit: edb4eb7 Signed-off-by: Arnaud Joset (arj) <[email protected]>
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Sep 4, 2024
If you created an event using GNOME Evolution/Calendar, it could add an `X-EVOLUTION-ENDDATE` parameter to the event's `RRULE`. When that happens, if the event is pushed to a Google Calendar and synced in Odoo, all participants' calendars stop syncing from there onwards. In https://discourse.gnome.org/t/working-with-evolution-mail-and-web-calendar-using-rrule-fail-because-of-x-evolution-enddate-in-rrule/19710/3 it explains why this happens and how it's actually a supported feature of RFC 5545. Dateutil doesn't support that feature. It just fails with `ValueError`. Progress is being tracked in dateutil/dateutil#1374. Regarding what matters to Odoo, we can just strip any X-named params from the RRULE prefix and value, and live happy with the rest (or fail if there's really a wrongly-formatted RRULE param). This way we avoid dateutil to fail unnecessarily and unlock users Google calendars synchronizations. We now store the full RRULE string when syncing, to avoid losing those parameters, in case someone wants to use them in the future. @moduon MT-6287 closes #178854 X-original-commit: edb4eb7 Signed-off-by: Arnaud Joset (arj) <[email protected]>
riccardoSANEHO
pushed a commit
to resultrum/odoo
that referenced
this pull request
Sep 30, 2024
If you created an event using GNOME Evolution/Calendar, it could add an `X-EVOLUTION-ENDDATE` parameter to the event's `RRULE`. When that happens, if the event is pushed to a Google Calendar and synced in Odoo, all participants' calendars stop syncing from there onwards. In https://discourse.gnome.org/t/working-with-evolution-mail-and-web-calendar-using-rrule-fail-because-of-x-evolution-enddate-in-rrule/19710/3 it explains why this happens and how it's actually a supported feature of RFC 5545. Dateutil doesn't support that feature. It just fails with `ValueError`. Progress is being tracked in dateutil/dateutil#1374. Regarding what matters to Odoo, we can just strip any X-named params from the RRULE prefix and value, and live happy with the rest (or fail if there's really a wrongly-formatted RRULE param). This way we avoid dateutil to fail unnecessarily and unlock users Google calendars synchronizations. We now store the full RRULE string when syncing, to avoid losing those parameters, in case someone wants to use them in the future. @moduon MT-6287 closes odoo#178814 X-original-commit: edb4eb7 Signed-off-by: Arnaud Joset (arj) <[email protected]>
adhoc-cicd-bot
pushed a commit
to adhoc-cicd/odoo-odoo
that referenced
this pull request
Jan 15, 2025
If you created an event using GNOME Evolution/Calendar, it could add an `X-EVOLUTION-ENDDATE` parameter to the event's `RRULE`. When that happens, if the event is pushed to a Google Calendar and synced in Odoo, all participants' calendars stop syncing from there onwards. In https://discourse.gnome.org/t/working-with-evolution-mail-and-web-calendar-using-rrule-fail-because-of-x-evolution-enddate-in-rrule/19710/3 it explains why this happens and how it's actually a supported feature of RFC 5545. Dateutil doesn't support that feature. It just fails with `ValueError`. Progress is being tracked in dateutil/dateutil#1374. Regarding what matters to Odoo, we can just strip any X-named params from the RRULE prefix and value, and live happy with the rest (or fail if there's really a wrongly-formatted RRULE param). This way we avoid dateutil to fail unnecessarily and unlock users Google calendars synchronizations. We now store the full RRULE string when syncing, to avoid losing those parameters, in case someone wants to use them in the future. @moduon MT-6287 closes odoo#171784 Signed-off-by: Arnaud Joset (arj) <[email protected]>
adhoc-cicd-bot
pushed a commit
to adhoc-cicd/odoo-odoo
that referenced
this pull request
Jan 20, 2025
If you created an event using GNOME Evolution/Calendar, it could add an `X-EVOLUTION-ENDDATE` parameter to the event's `RRULE`. When that happens, if the event is pushed to a Google Calendar and synced in Odoo, all participants' calendars stop syncing from there onwards. In https://discourse.gnome.org/t/working-with-evolution-mail-and-web-calendar-using-rrule-fail-because-of-x-evolution-enddate-in-rrule/19710/3 it explains why this happens and how it's actually a supported feature of RFC 5545. Dateutil doesn't support that feature. It just fails with `ValueError`. Progress is being tracked in dateutil/dateutil#1374. Regarding what matters to Odoo, we can just strip any X-named params from the RRULE prefix and value, and live happy with the rest (or fail if there's really a wrongly-formatted RRULE param). This way we avoid dateutil to fail unnecessarily and unlock users Google calendars synchronizations. We now store the full RRULE string when syncing, to avoid losing those parameters, in case someone wants to use them in the future. @moduon MT-6287 closes odoo#171784 Signed-off-by: Arnaud Joset (arj) <[email protected]>
adhoc-cicd-bot
pushed a commit
to adhoc-cicd/odoo-odoo
that referenced
this pull request
Jan 27, 2025
If you created an event using GNOME Evolution/Calendar, it could add an `X-EVOLUTION-ENDDATE` parameter to the event's `RRULE`. When that happens, if the event is pushed to a Google Calendar and synced in Odoo, all participants' calendars stop syncing from there onwards. In https://discourse.gnome.org/t/working-with-evolution-mail-and-web-calendar-using-rrule-fail-because-of-x-evolution-enddate-in-rrule/19710/3 it explains why this happens and how it's actually a supported feature of RFC 5545. Dateutil doesn't support that feature. It just fails with `ValueError`. Progress is being tracked in dateutil/dateutil#1374. Regarding what matters to Odoo, we can just strip any X-named params from the RRULE prefix and value, and live happy with the rest (or fail if there's really a wrongly-formatted RRULE param). This way we avoid dateutil to fail unnecessarily and unlock users Google calendars synchronizations. We now store the full RRULE string when syncing, to avoid losing those parameters, in case someone wants to use them in the future. @moduon MT-6287 closes odoo#171784 Signed-off-by: Arnaud Joset (arj) <[email protected]>
adhoc-cicd-bot
pushed a commit
to adhoc-cicd/odoo-odoo
that referenced
this pull request
Jan 27, 2025
If you created an event using GNOME Evolution/Calendar, it could add an `X-EVOLUTION-ENDDATE` parameter to the event's `RRULE`. When that happens, if the event is pushed to a Google Calendar and synced in Odoo, all participants' calendars stop syncing from there onwards. In https://discourse.gnome.org/t/working-with-evolution-mail-and-web-calendar-using-rrule-fail-because-of-x-evolution-enddate-in-rrule/19710/3 it explains why this happens and how it's actually a supported feature of RFC 5545. Dateutil doesn't support that feature. It just fails with `ValueError`. Progress is being tracked in dateutil/dateutil#1374. Regarding what matters to Odoo, we can just strip any X-named params from the RRULE prefix and value, and live happy with the rest (or fail if there's really a wrongly-formatted RRULE param). This way we avoid dateutil to fail unnecessarily and unlock users Google calendars synchronizations. We now store the full RRULE string when syncing, to avoid losing those parameters, in case someone wants to use them in the future. @moduon MT-6287 closes odoo#171784 Signed-off-by: Arnaud Joset (arj) <[email protected]>
adhoc-cicd-bot
pushed a commit
to adhoc-cicd/odoo-odoo
that referenced
this pull request
Jan 28, 2025
If you created an event using GNOME Evolution/Calendar, it could add an `X-EVOLUTION-ENDDATE` parameter to the event's `RRULE`. When that happens, if the event is pushed to a Google Calendar and synced in Odoo, all participants' calendars stop syncing from there onwards. In https://discourse.gnome.org/t/working-with-evolution-mail-and-web-calendar-using-rrule-fail-because-of-x-evolution-enddate-in-rrule/19710/3 it explains why this happens and how it's actually a supported feature of RFC 5545. Dateutil doesn't support that feature. It just fails with `ValueError`. Progress is being tracked in dateutil/dateutil#1374. Regarding what matters to Odoo, we can just strip any X-named params from the RRULE prefix and value, and live happy with the rest (or fail if there's really a wrongly-formatted RRULE param). This way we avoid dateutil to fail unnecessarily and unlock users Google calendars synchronizations. We now store the full RRULE string when syncing, to avoid losing those parameters, in case someone wants to use them in the future. @moduon MT-6287 closes odoo#171784 Signed-off-by: Arnaud Joset (arj) <[email protected]>
agb80
added a commit
to agb80/OCB
that referenced
this pull request
Sep 18, 2025
If you created an event using GNOME Evolution/Calendar, it could add an `X-EVOLUTION-ENDDATE` parameter to the event's `RRULE`. When that happens, if the event is pushed to a Google Calendar and synced in Odoo, all participants' calendars stop syncing from there onwards. In https://discourse.gnome.org/t/working-with-evolution-mail-and-web-calendar-using-rrule-fail-because-of-x-evolution-enddate-in-rrule/19710/3 it explains why this happens and how it's actually a supported feature of RFC 5545. Dateutil doesn't support that feature. It just fails with `ValueError`. Progress is being tracked in dateutil/dateutil#1374. Regarding what matters to Odoo, we can just strip any X-named params from the RRULE prefix and value, and live happy with the rest (or fail if there's really a wrongly-formatted RRULE param). This way we avoid dateutil to fail unnecessarily and unlock users Google calendars synchronizations. We now store the full RRULE string when syncing, to avoid losing those parameters, in case someone wants to use them in the future. @moduon MT-6287
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These kind of properties are allowed by RFC 5545 and used in the wild for storing various non-standard information.
One example is how GNOME Evolution caches RRULE ends.
With this fix, we avoid failing unnecessarily on such RRULE.
@moduon MT-6287
Summary of changes
Closes
Pull Request Checklist