Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@davep
Copy link
Owner

@davep davep commented Jan 23, 2026

Closes #36.

TODO:

This is fine moving on the server, and is fine in terms of moving the subscription itself, but the folder unread counts go wrong because the folder associated with every single article of the subscription will also need moving. So:

  • Locally update the case of moving from no folder to a folder.
  • Locally update the case of moving from a folder to no folder.
  • Locally update the case of moving from one folder to another.

@davep davep self-assigned this Jan 23, 2026
@davep davep added Enhancement New feature or request TODO A thing I'm planning on doing labels Jan 23, 2026
@davep
Copy link
Owner Author

davep commented Jan 24, 2026

Keeping the local counts in sync with the server counts is now working, I believe, although more testing is needed.

What is interesting is that it seems that if you ask to move a subscription from a folder to a folder called "" this will break your ability to use the API of TheOldReader. If I subsequently attempted to stream article IDs after doing that it gave me a 404 during the stream. I had to "low level" unsubscribe from the feed before I could make use of the stream API again.

I think this means I should tweak the move method in OldAS so that it handles an empty string as a "remove from folder" operation (currently it only does that if you pass None as that parameter, or omit it); but I might also want to drop a line to the ToR folk and point out what looks to be a wee bug in their API.

@davep
Copy link
Owner Author

davep commented Jan 24, 2026

Also see davep/oldas#27 which relates to this. Right now the PR won't let you move a subscription outwith of any folder (because of the API problem I ran into), but I think this should be safe and possible after I tweak OldAS to handle an empty folder name.

I could also test/fix this by passing None when it's an empty folder name, but I feel it's safer to fix it in the core library.

@davep davep marked this pull request as ready for review January 25, 2026 11:46
@davep davep merged commit 00ce6c0 into main Jan 25, 2026
4 checks passed
@davep davep deleted the move-subscription branch January 25, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request TODO A thing I'm planning on doing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the ability to move a subscription from one folder to another

2 participants