Don't emit non-standard .phdr and .shdr section headers #957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other linkers don't emit sections for these parts of the file. Also, using SHT_NULL for sections other than section 0 causes problems for some tools, such as GNU strip.
marxin
approved these changes
Jun 29, 2025
Collaborator
marxin
left a comment
There was a problem hiding this comment.
I can confirm it fixed the gpm shared library, where strip command now makes the library unbroken.
Collaborator
|
@davidlattimore Should we close the reported issue (https://sourceware.org/bugzilla/show_bug.cgi?id=33119) as invalid, or is the patch still worth being accepted? Note that llvm-strip works fine. |
Owner
Author
I'd say comment on the issue that the linker in question has been updated to not emit those sections. They may still decide that they want to make the change. |
Collaborator
|
Yep, I've just sent the comment, leaving the decision to them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other linkers don't emit sections for these parts of the file. Also, using SHT_NULL for sections other than section 0 causes problems for some tools, such as GNU strip.