Support flag --no-mmap-output-file#1215
Merged
davidlattimore merged 1 commit intomainfrom Oct 16, 2025
Merged
Conversation
mati865
approved these changes
Oct 16, 2025
Collaborator
mati865
left a comment
There was a problem hiding this comment.
With sufficient amount of threads, this flag is an improvement for BTRFS, EXT4, F2FS and XFS, and a regression for tmpfs and ZFS.
Unless --update-in-place is also passed, that flag + mmap is the best everywhere except BTRFS.
fffab75 to
6a6c68d
Compare
mati865
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.