-
Notifications
You must be signed in to change notification settings - Fork 18
Feature/upgrade light functionality #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@dbuezas do you know any easy way to test this change with my HA 🤔 ? |
0f92529 to
08c73a0
Compare
|
Hi 👋 yes it is quite easy to test, just copy the files you modified to your home assistant computer, inside config/custom_components/icsee-ptz. Then restart home assistant. I suggest you try the samba mount add on so you can access the home assistant folders directly from your pc as a network drive. https://github.com/home-assistant/addons/blob/master/samba/DOCS.md |
faadaf9 to
68b4aa3
Compare
68b4aa3 to
f1ba211
Compare
|
@dbuezas i guess the code is good to review :) |
|
Cool, thanks! |
Did you test your camera with this code? Because I tested a old one and both are working with this code. Did you updated your app? I don't know, but I guess it comes in a new update. |
|
In theory your camera should work, because it is the new parameter that icsee app is using |
|
I have a camera that work with old config, and this camera worked with this new parameter as well, for this reason I guess it should also work for you |
|
As I said, it is the wild west. |
|
Lets keep both for a while :) |
Should I create a new select for this? |
993efa6 to
0f1f65a
Compare
|
Could you check again @dbuezas please :) |
dbuezas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :👍
|
I don't have a computer for some weeks but it looks good! |
when you have some time could you generate a |
|
Done (pre-release) |
a new parameter was introduced to handle lights