Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@eerison
Copy link
Contributor

@eerison eerison commented Dec 18, 2023

a new parameter was introduced to handle lights

@eerison
Copy link
Contributor Author

eerison commented Dec 18, 2023

@dbuezas do you know any easy way to test this change with my HA 🤔 ?

@eerison eerison force-pushed the update-light-functionality branch from 0f92529 to 08c73a0 Compare December 18, 2023 17:39
@dbuezas
Copy link
Owner

dbuezas commented Dec 19, 2023

Hi 👋 yes it is quite easy to test, just copy the files you modified to your home assistant computer, inside config/custom_components/icsee-ptz. Then restart home assistant.

I suggest you try the samba mount add on so you can access the home assistant folders directly from your pc as a network drive.

https://github.com/home-assistant/addons/blob/master/samba/DOCS.md

@eerison eerison force-pushed the update-light-functionality branch 2 times, most recently from faadaf9 to 68b4aa3 Compare December 19, 2023 14:49
@eerison eerison marked this pull request as ready for review December 19, 2023 14:49
@eerison eerison requested a review from dbuezas December 19, 2023 14:49
@eerison eerison marked this pull request as draft December 19, 2023 15:41
@eerison eerison force-pushed the update-light-functionality branch from 68b4aa3 to f1ba211 Compare December 19, 2023 15:45
@eerison eerison marked this pull request as ready for review December 19, 2023 15:45
@eerison
Copy link
Contributor Author

eerison commented Dec 19, 2023

@dbuezas i guess the code is good to review :)

@dbuezas
Copy link
Owner

dbuezas commented Dec 19, 2023

Cool, thanks!
Can you readd the deleted one? The cameras are a bit like the wild west, mine worked with the old config

@eerison
Copy link
Contributor Author

eerison commented Dec 19, 2023

Cool, thanks! Can you readd the deleted one? The cameras are a bit like the wild west, mine worked with the old config

Did you test your camera with this code?

Because I tested a old one and both are working with this code.

Did you updated your app? I don't know, but I guess it comes in a new update.

@eerison
Copy link
Contributor Author

eerison commented Dec 19, 2023

In theory your camera should work, because it is the new parameter that icsee app is using

@eerison
Copy link
Contributor Author

eerison commented Dec 19, 2023

I have a camera that work with old config, and this camera worked with this new parameter as well, for this reason I guess it should also work for you

@dbuezas
Copy link
Owner

dbuezas commented Dec 19, 2023

As I said, it is the wild west.
I don't update cameras anymore because some started using their custom video protocol and go2rtc doesn't work well with it.

@dbuezas
Copy link
Owner

dbuezas commented Dec 19, 2023

Lets keep both for a while :)

@eerison
Copy link
Contributor Author

eerison commented Dec 19, 2023

Lets keep both for a while :)

Should I create a new select for this?
Or how can I keep both?

@eerison eerison force-pushed the update-light-functionality branch from 993efa6 to 0f1f65a Compare December 19, 2023 21:24
@eerison
Copy link
Contributor Author

eerison commented Dec 19, 2023

Could you check again @dbuezas please :)

Copy link
Owner

@dbuezas dbuezas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :👍

@dbuezas
Copy link
Owner

dbuezas commented Dec 19, 2023

I don't have a computer for some weeks but it looks good!
Thanks for the contribution!

@dbuezas dbuezas merged commit e18f49c into dbuezas:main Dec 19, 2023
@eerison eerison deleted the update-light-functionality branch December 19, 2023 21:38
@eerison
Copy link
Contributor Author

eerison commented Dec 19, 2023

I don't have a computer for some weeks but it looks good! Thanks for the contribution!

when you have some time could you generate a release or pre-release 👀

@dbuezas
Copy link
Owner

dbuezas commented Dec 19, 2023

Done (pre-release)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants