Conversation
|
Download the artifacts for this pull request:
See Testing a PR. |
…ddev#7415) [skip buildkite]" This reverts commit 8a44505.
626d2f7 to
1c28677
Compare
golangci-lint to v2.2.1, remove only-new-issues, for #7415skip-package-name-checks, pin golangci-lint to v2.2.1, remove only-new-issues, for #7415
Member
Author
|
Static Validation doesn't complain anymore https://github.com/ddev/ddev/actions/runs/15978385040/job/45066665574?pr=7416#step:5:32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
There are some more warnings related to:
And @rfay pointed out that behavior added in the PR below is confusing:
How This PR Solves The Issue
skip-package-name-checksto disable this check. It often reports inconsistent results, likely due to caching issues (golangci-lint cache clean && golangci-lint run)only-new-issues, so full lint checks run on PRs.golangci-lintto v2.2.1, which avoids future breakage from upstream changes. This adds some maintenance since we need to bump it manually, but it prevents unexpected linter failures.Manual Testing Instructions
Automated Testing Overview
Release/Deployment Notes