Conversation
|
Download the artifacts for this pull request:
See Testing a PR. |
nickchomey
reviewed
Jul 29, 2025
| nsExec::ExecToStack 'wsl -d $R1 -u root cp "$WSL_WINDOWS_TEMP/ddev_installer/$R0" /tmp/' | ||
| ; Remove any existing script first, then copy from Windows temp to WSL2 /tmp | ||
| nsExec::ExecToStack 'wsl -d $R1 -u root rm -f /tmp/$R0' | ||
| nsExec::ExecToStack 'wsl -d $R1 cp "$WSL_WINDOWS_TEMP/ddev_installer/$R0" /tmp/' |
Collaborator
There was a problem hiding this comment.
Can I suggest ~/tmp instead of /tmp? Would, of course, need to make the change elsewhere as well
Member
Author
There was a problem hiding this comment.
I use ~/tmp also, but creating that means intrusive behavior on the user's distro, which is something we try not to do.
Thanks for reading and following.
Could you try the artifact in #7493 (comment) ? You have to click around the Windows Defender warning because PR builds aren't signed.
Collaborator
There was a problem hiding this comment.
Sure, I'll try it in an hour or two and report back
Collaborator
|
This seems to have worked. I dont see anything in the log - including that mkcert ran properly this time, since its not owned by root anymore. |
Collaborator
|
Though, i do see these .exe files - should they be there? |
Member
Author
|
Yay! Yes, those belong |
Member
Author
|
Now we'll have a signed version of the installer we can recommend to people if this crops up again. Thanks so much for all the work on this @nickchomey , looking forward to hearing your further experiences. |
Collaborator
|
My pleasure. I still do think that it would be good if the installer cleaned up the Windows Program Files side if/after it installed everything in wsl2. It's a minor thing, but would be in-line with what the blog post says and the general effort to streamline things and have ddev not overstep it's bounds. |
Member
Author
|
The installer provides mkcert.exe and ddev-hostname.exe on the Windows side so that people don't have to have ddev-wsl2. But of course if they're using the installer, they will have it... But the installer itself uses mkcert.exe on the Windows side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
This is an experimental Windows Installer build to try to solve problems reported during "Failed to copy script" in the Windows installer.
How This PR Solves The Issue
As suggested by @nickchomey in #7477 this attempts to do the copying of scripts into the distro using the default user instead of root, and tries to get more information about what the failure might be
Manual Testing Instructions
Automated Testing Overview
No changes.
Release/Deployment Notes