chore(deps): update vendor to current, fixes #7624#7643
Merged
Conversation
ac1855c to
5a8bc78
Compare
|
Download the artifacts for this pull request:
See Testing a PR. |
stasadev
reviewed
Sep 22, 2025
rfay
added a commit
to rfay/ddev
that referenced
this pull request
Sep 22, 2025
Addresses feedback from @stasadev in PR ddev#7643. This update includes: - **Upgraded pb dependency**: Migrated from github.com/cheggaaa/pb v1.0.29 to v3.1.7 - **Updated govalidator**: Changed to use master branch for latest features - **Fixed progress bar API**: Updated network.go to use pb/v3 API: - pb.New() → pb.New64() for int64 support - .SetUnits(pb.U_BYTES) → .Set(pb.Bytes, true) - .Prefix() → .Set("prefix", value) - **Vendor updates**: Refreshed vendor directory with new dependencies 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Member
Author
|
Updated those as suggested. pb/v3 needed a little bit of fiddling to get it working. Recommend testing progress bar with |
Fix non-constant format string issues identified by golangci-lint: - Add "%s" format strings to prevent format string injection - Change Printf to Print where no formatting is needed - Ensure all dynamic strings are properly handled in printf calls Files changed: - pkg/ddevapp/config.go: Fix util.Debug call and error output formatting - cmd/ddev/cmd/delete-images.go: Add format string to image output - cmd/ddev/cmd/dotenv-get.go: Use Print for raw environment variable output - pkg/util/utils.go: Fix Debug and Verbose function format string handling 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Addresses feedback from @stasadev in PR ddev#7643. This update includes: - **Upgraded pb dependency**: Migrated from github.com/cheggaaa/pb v1.0.29 to v3.1.7 - **Updated govalidator**: Changed to use master branch for latest features - **Fixed progress bar API**: Updated network.go to use pb/v3 API: - pb.New() → pb.New64() for int64 support - .SetUnits(pb.U_BYTES) → .Set(pb.Bytes, true) - .Prefix() → .Set("prefix", value) - **Vendor updates**: Refreshed vendor directory with new dependencies 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
97aa04a to
811e363
Compare
Member
Author
|
Thanks! |
Member
Author
|
Now only 741 files changed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
How This PR Solves The Issue
Update, run tests
Read every single line. Only 510 files changed.