Conversation
|
Download the artifacts for this pull request:
See Testing a PR. |
2 tasks
rfay
approved these changes
Apr 17, 2025
Member
rfay
left a comment
There was a problem hiding this comment.
This looks correct to me and tests great. Please do update the OP manual testing instructions to explain what should and should not happen, and what is happening to PhpStorm with the plugin installed, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
ddev xdebug toggleandddev xdebug statushang if xdebug is enabled and an IDE is listening for xdebug #6191When xdebug is enabled, DDEV internal executions of PHP code are not excluded from debugging, causing unexpected debugging connections in the IDE.
How This PR Solves The Issue
For xdebug 2 support, we'd first need to figure out the xdebug version. Seeing as the composer command also implements the xdebug 3 only solution, this is what I went with here as well.
Manual Testing Instructions
Setup:
Take any ddev project, can also be a completely new and blank one
ddev config global --xhprof-mode=xhgui
ddev start
ddev xdebug on
Enable xdebug listen in PhpStorm
Test the following commands. Running either causes a debug connection in the IDE with DDEV 1.24.4 that looks like the screenshot, while no longer creating one with this version:
ddev xdebug status
ddev describe
ddev describe is called by the PhpStorm plugin in regular intervals to watch the project's status, so stopping debugging connections from happening here resolves ddev/ddev-intellij-plugin#414
Automated Testing Overview
Might be useful. That the changes don't break existing functionality is already covered by existing tests. What isn't tested, is that they remove the xdebug connection attempt.
Release/Deployment Notes
No change for deployment, the commands behave as before, minus the debugging connections.