fix: change download timeout to 5 minutes instead of 20s, fixes #7298#7300
Merged
fix: change download timeout to 5 minutes instead of 20s, fixes #7298#7300
Conversation
|
Download the artifacts for this pull request:
See Testing a PR. |
Member
Author
|
New message example: |
4 tasks
stasadev
approved these changes
May 15, 2025
Member
stasadev
left a comment
There was a problem hiding this comment.
Thank you, looks good to me!
| client.Backoff = retryablehttp.DefaultBackoff | ||
| client.Logger = nil | ||
| client.HTTPClient.Timeout = 20 * time.Second | ||
| client.HTTPClient.Timeout = 5 * time.Minute |
Contributor
There was a problem hiding this comment.
Is this change only for downloading images on upgrade? If not, what other scenarios use this timeout?
Member
Author
There was a problem hiding this comment.
Has nothing to do with docker images, only things that use DownloadFile(), which means docker-compose, mutagen, and ddev add-on get downloads at this point.
Member
Author
|
OK, going with it. Having this in HEAD may make it easier for some people to test/use it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
On slower networks, the download of docker-compose times out in just 20s and gives an odd message
How This PR Solves The Issue
Manual Testing Instructions
I used network conditioning in Parallels to slow the download speed to 20Mbps to reproduce this.
Running TestDockerComposeDownload with the network slowed down shows the failure at 20s, but it succeed with this fix.
Automated Testing Overview
Release/Deployment Notes