Thanks to visit codestin.com
Credit goes to github.com

Skip to content

build: use yaml/go-yaml instead of unmaintained yaml.v3, fixes #7280#7381

Merged
rfay merged 3 commits intoddev:mainfrom
rfay:20250615_rfay_yaml_go_yaml
Jun 16, 2025
Merged

build: use yaml/go-yaml instead of unmaintained yaml.v3, fixes #7280#7381
rfay merged 3 commits intoddev:mainfrom
rfay:20250615_rfay_yaml_go_yaml

Conversation

@rfay
Copy link
Member

@rfay rfay commented Jun 15, 2025

The Issue

yaml/go-yaml seems to have reached some kind of maturity

How This PR Solves The Issue

Try it out.

Manual Testing Instructions

Look at test results. Use it. Tests should tell us everything.

Automated Testing Overview

Release/Deployment Notes

@github-actions github-actions bot added dependencies Pull requests that update a dependency file maintenance labels Jun 15, 2025
@github-actions
Copy link

github-actions bot commented Jun 15, 2025

@rfay rfay marked this pull request as ready for review June 15, 2025 18:35
@rfay rfay requested review from a team as code owners June 15, 2025 18:35
@rfay rfay requested a review from stasadev June 15, 2025 18:35
@rfay
Copy link
Member Author

rfay commented Jun 15, 2025

Updated mergo to lose its dependency.

The traditional module is still required by stretchr/testify, which is used in testcommon tests (assert)

$ go mod why gopkg.in/yaml.v3
# gopkg.in/yaml.v3
github.com/ddev/ddev/pkg/testcommon
github.com/stretchr/testify/assert
github.com/stretchr/testify/assert/yaml
gopkg.in/yaml.v3

Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@rfay rfay merged commit f010dd6 into ddev:main Jun 16, 2025
21 of 23 checks passed
@rfay rfay deleted the 20250615_rfay_yaml_go_yaml branch June 16, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments