Move empty pattern check into while loop #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpburnett
approved these changes
Aug 19, 2024
|
Thank you! |
|
This feels weird to me -- isn't it the same as "if (handle->pattern.empty()) { return false; }"? |
I don't completely understand the context here, but the handle's directory iterator not being iterated through was causing the file not found error in the linked issue due to an early return when there was an empty pattern, so that's why i moved it to the while loop. Maybe there is a better fix, but I wanted to get something in here as it was breaking multiple projects using wibo with EDIT: Okay yeah this makes more sense lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #78