Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[candi] Provide featureGate configuration by moduleConfig #16185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

[candi] Provide featureGate configuration by moduleConfig #16185

wants to merge 22 commits into from

Conversation

@trofimovdals
Copy link
Contributor

@trofimovdals trofimovdals commented Oct 27, 2025 •
edited
Loading

Description

User may configure k8s featueGates by control-plane-manager moduleconfig using enabledFeatureGates settings.

The first part to enable users to manage k8s featureGates:

  • Provide featureGate generator for make generate
  • File candi/feature_gates/feature_gates_map.yml - contains information about k8s version and available/forbidden featureGates.
  • candi/feature_gates/feature_gates_generated.go - contains generated go package with k8sVersion-featureGate map
  • candi/feature_gates/feature_gates_generated.py - contains generated python dict with k8sVersion-featureGate map
  • Add GetFeatureGateInfo helper function

Step two:

  • Make go hook for parse and validate enabledFeatureGates params from moduleconfig

Why do we need it, and what problem does it solve?

Adds process for management k8s featureGates

Why do we need it in the patch release (if we do)?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: candi
type: feature
summary: Adds process for management k8s featureGates
impact_level: default

@github-actions github-actions bot added area/testing Pull requests that update testing code area/cluster-and-infrastructure Pull requests that update infra modules go Pull requests that update Go code python Pull requests that update Python code labels Oct 27, 2025
fix
af7e962 
Signed-off-by: dmitry.trofimov <[email protected]>
@trofimovdals trofimovdals force-pushed the feature/feature-gate-generator branch from 1068da4 to af7e962 Compare October 27, 2025 10:37
dmitry.trofimov added 2 commits October 27, 2025 13:39
fix
2d103f3 
Signed-off-by: dmitry.trofimov <[email protected]>
fix
9686d24 
Signed-off-by: dmitry.trofimov <[email protected]>
@trofimovdals trofimovdals added this to the v1.74.0 milestone Oct 27, 2025
@trofimovdals trofimovdals requested a review from sprait October 27, 2025 11:47
add helper functions
2e0bb2d 
Signed-off-by: dmitry.trofimov <[email protected]>
@trofimovdals trofimovdals added the e2e/run/yandex-cloud Run e2e tests in Yandex Cloud label Oct 28, 2025
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Oct 28, 2025 •
edited
Loading

🟢 e2e: Yandex.Cloud for deckhouse:feature/feature-gate-generator succeeded in 38m12s.

Workflow details

Yandex.Cloud-WithoutNAT-Containerd-1.30 - Connection string: ssh [email protected]

🟢 e2e: Yandex.Cloud, Containerd, Kubernetes 1.30 succeeded in 36m55s.

@github-actions github-actions bot removed the e2e/run/yandex-cloud Run e2e tests in Yandex Cloud label Oct 28, 2025
@trofimovdals trofimovdals marked this pull request as ready for review October 28, 2025 08:20
@trofimovdals trofimovdals requested a review from name212 as a code owner October 28, 2025 08:20
fix
80ebcfe 
Signed-off-by: dmitry.trofimov <[email protected]>
@github-actions github-actions bot added the area/api-change Pull requests that api changing label Oct 30, 2025
fix
da07b11 
Signed-off-by: dmitry.trofimov <[email protected]>
@trofimovdals trofimovdals added the e2e/run/yandex-cloud Run e2e tests in Yandex Cloud label Oct 30, 2025
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Oct 30, 2025 •
edited
Loading

🟢 e2e: Yandex.Cloud for deckhouse:feature/feature-gate-generator succeeded in 36m36s.

Workflow details

Yandex.Cloud-WithoutNAT-Containerd-1.30 - Connection string: ssh [email protected]

🟢 e2e: Yandex.Cloud, Containerd, Kubernetes 1.30 succeeded in 35m26s.

@github-actions github-actions bot removed the e2e/run/yandex-cloud Run e2e tests in Yandex Cloud label Oct 30, 2025
dmitry.trofimov added 2 commits October 31, 2025 11:38
added go hook
1b17103 
Signed-off-by: dmitry.trofimov <[email protected]>
fix
a471660 
Signed-off-by: dmitry.trofimov <[email protected]>
@trofimovdals trofimovdals marked this pull request as draft October 31, 2025 08:57
dmitry.trofimov added 2 commits October 31, 2025 12:01
fix
bc37881 
Signed-off-by: dmitry.trofimov <[email protected]>
fix
a4eefe3 
Signed-off-by: dmitry.trofimov <[email protected]>
@trofimovdals trofimovdals changed the title [candi] Add featureGate generator [candi] Provide featureGate configuration by moduleConfig Oct 31, 2025
fix
f2c3768 
Signed-off-by: dmitry.trofimov <[email protected]>
@trofimovdals trofimovdals added the e2e/run/yandex-cloud Run e2e tests in Yandex Cloud label Oct 31, 2025
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Oct 31, 2025 •
edited
Loading

🔴 e2e: Yandex.Cloud for deckhouse:feature/feature-gate-generator failed in 17m1s.

E2e for yandex-cloud WithoutNAT;containerd;1.30 was failed. Use:
ssh -i ~/.ssh/e2e-id-rsa [email protected] - connect for debugging;

/e2e/abort yandex-cloud;WithoutNAT;containerd;1.30 18976755830 18976755830-1-con-1-30 /sys/deckhouse-oss/install:pr16185 [email protected] - for abort failed cluster

Workflow details (1 job failed)

Yandex.Cloud-WithoutNAT-Containerd-1.30 - Connection string: ssh [email protected]

🔴 e2e: Yandex.Cloud, Containerd, Kubernetes 1.30 failed in 15m43s.

@github-actions github-actions bot removed the e2e/run/yandex-cloud Run e2e tests in Yandex Cloud label Oct 31, 2025
fix
b9932f6 
Signed-off-by: dmitry.trofimov <[email protected]>
@trofimovdals
Copy link
Contributor Author

trofimovdals commented Oct 31, 2025

/e2e/abort yandex-cloud;WithoutNAT;containerd;1.30 18976755830 18976755830-1-con-1-30 /sys/deckhouse-oss/install:pr16185 [email protected]

@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Oct 31, 2025 •
edited
Loading

🟢 destroy cluster: Yandex.Cloud for refs/heads/main succeeded in 3m25s.

Workflow details

🟢 destroy cluster: Yandex.Cloud, Containerd, Kubernetes 1.30 succeeded in 3m2s.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/cluster/failed Pull request contains failed e2e cluster label Oct 31, 2025
@trofimovdals
Copy link
Contributor Author

trofimovdals commented Oct 31, 2025

/e2e/abort yandex-cloud;WithoutNAT;containerd;1.30 18968453296 18968453296-1-con-1-30 /sys/deckhouse-oss/install:pr16185 [email protected]

@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Oct 31, 2025 •
edited
Loading

🟢 destroy cluster: Yandex.Cloud for refs/heads/main succeeded in 6m40s.

Workflow details

🟢 destroy cluster: Yandex.Cloud, Containerd, Kubernetes 1.30 succeeded in 6m16s.

@trofimovdals trofimovdals added the e2e/run/yandex-cloud Run e2e tests in Yandex Cloud label Oct 31, 2025
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Oct 31, 2025 •
edited
Loading

🟢 e2e: Yandex.Cloud for deckhouse:feature/feature-gate-generator succeeded in 33m57s.

Workflow details

Yandex.Cloud-WithoutNAT-Containerd-1.30 - Connection string: ssh [email protected]

🟢 e2e: Yandex.Cloud, Containerd, Kubernetes 1.30 succeeded in 32m41s.

@github-actions github-actions bot removed the e2e/run/yandex-cloud Run e2e tests in Yandex Cloud label Oct 31, 2025
dmitry.trofimov added 2 commits October 31, 2025 18:56
fix
1c79ef4 
Signed-off-by: dmitry.trofimov <[email protected]>
fix
01cbb38 
Signed-off-by: dmitry.trofimov <[email protected]>
@trofimovdals trofimovdals added the e2e/run/yandex-cloud Run e2e tests in Yandex Cloud label Nov 1, 2025
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Nov 1, 2025 •
edited
Loading

🔴 e2e: Yandex.Cloud for deckhouse:feature/feature-gate-generator failed in 39m58s.

E2e for yandex-cloud WithoutNAT;containerd;1.30 was failed. Use:
ssh -i ~/.ssh/e2e-id-rsa [email protected] - connect for debugging;

/e2e/abort yandex-cloud;WithoutNAT;containerd;1.30 18993203673 18993203673-1-con-1-30 /sys/deckhouse-oss/install:pr16185 [email protected] - for abort failed cluster

Workflow details (1 job failed)

Yandex.Cloud-WithoutNAT-Containerd-1.30 - Connection string: ssh [email protected]

🔴 e2e: Yandex.Cloud, Containerd, Kubernetes 1.30 failed in 38m48s.

@github-actions github-actions bot removed the e2e/run/yandex-cloud Run e2e tests in Yandex Cloud label Nov 1, 2025
fix
4c44fdd 
Signed-off-by: dmitry.trofimov <[email protected]>
@deckhouse-BOaTswain deckhouse-BOaTswain added the e2e/cluster/failed Pull request contains failed e2e cluster label Nov 1, 2025
dmitry.trofimov added 5 commits November 1, 2025 11:03
fix
7f3552a 
Signed-off-by: dmitry.trofimov <[email protected]>
fix
32ab7a5 
Signed-off-by: dmitry.trofimov <[email protected]>
fix
55e90b8 
Signed-off-by: dmitry.trofimov <[email protected]>
fix
6b67272 
Signed-off-by: dmitry.trofimov <[email protected]>
fix
1432c71 
Signed-off-by: dmitry.trofimov <[email protected]>
@trofimovdals
Copy link
Contributor Author

trofimovdals commented Nov 1, 2025

image

@trofimovdals
Copy link
Contributor Author

trofimovdals commented Nov 1, 2025

/e2e/abort yandex-cloud;WithoutNAT;containerd;1.30 18993203673 18993203673-1-con-1-30 /sys/deckhouse-oss/install:pr16185 [email protected]

@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Nov 1, 2025 •
edited
Loading

🟢 destroy cluster: Yandex.Cloud for refs/heads/main succeeded in 6m10s.

Workflow details

🟢 destroy cluster: Yandex.Cloud, Containerd, Kubernetes 1.30 succeeded in 5m48s.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/cluster/failed Pull request contains failed e2e cluster label Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@z9r5 z9r5 z9r5 approved these changes

@sprait sprait Awaiting requested review from sprait sprait is a code owner

@name212 name212 Awaiting requested review from name212 name212 is a code owner

@nabokihms nabokihms Awaiting requested review from nabokihms nabokihms is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@trofimovdals trofimovdals

Labels

area/api-change Pull requests that api changing area/cluster-and-infrastructure Pull requests that update infra modules area/testing Pull requests that update testing code go Pull requests that update Go code python Pull requests that update Python code

Projects

None yet

Milestone

v1.74.0

Development

Successfully merging this pull request may close these issues.

4 participants

@trofimovdals @deckhouse-BOaTswain @z9r5