Miscellaneous comment/log updates. #2553
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67a5d6d to
2cc8ae7
Compare
jrick
reviewed
Oct 28, 2025
ticketbuyer/tb.go
Outdated
Comment on lines
136
to
140
| // Skip this purchase when no more tickets may be purchased in the interval and | ||
| // the next sdiff is unknown. The earliest any ticket may be mined is two | ||
| // blocks from now, with the next block containing the split transaction | ||
| // that the ticket purchase spends. | ||
| // Skip this purchase when no more tickets may be purchased in | ||
| // the interval and the next sdiff is unknown. The earliest any | ||
| // ticket may be mined is two blocks from now, with the next | ||
| // block containing the split transaction that the ticket | ||
| // purchase spends. |
There was a problem hiding this comment.
rewrapping comments with no textual changes seems like unnecessary churn.
dcrwallet doesn't have a strict column limit, and nobody can seem to even agree on what it would be if we wanted one because we all use different tab stops.
There was a problem hiding this comment.
Fair enough, removed those changes.
jrick
reviewed
Oct 29, 2025
wallet/mixing.go
Outdated
|
|
||
| // MixAccount individually mixes outputs of an account into standard | ||
| // denominations, creating newly mixed outputs for a mixed account. | ||
| // denominations, creating newly mixed outputs for a mixed account.This is a |
There was a problem hiding this comment.
i'm personally a fan of two spaces after periods, and held my tongue for all of the single spaces you're adding, but no spaces at all is going too far.
There was a problem hiding this comment.
doesn't look like it, got lost in the rebase?
There was a problem hiding this comment.
oops. Fixed for real this time...
3bcdb30 to
eda92e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A collection of small miscellaneous changes I have accumulated whilst working on other things; mostly comment and log message updates.