Log/comment updates for mixing. #2563
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbbd4ac to
aa16333
Compare
Its nicer to have an explicit log for this case rather than "Mixed 0 of 0 selected outputs of account 2".
aa16333 to
8f07068
Compare
jrick
requested changes
Nov 3, 2025
Comment on lines
+489
to
+490
| case errors.Is(err, context.Canceled): | ||
| err = nil |
There was a problem hiding this comment.
I don't agree with this change. The commit description says
"Don't log error when account mixer is canceled."
but we are logging at debug below.
This doesn't just suppress the log; it changes the return value.
The only other places we would be logging an error will be in other systems that call this wallet method (jsonrpc, grpc, and the auto ticketbuyer). We already suppress this error log in the autobuyer, and I don't think it makes sense to not return this error up to the rpc handlers (if they disconnect, they wouldn't receive the rpc error anyways).
| w.lockedOutpointMu.Unlock() | ||
|
|
||
| if len(credits) == 0 { | ||
| log.Debugf("No outputs eligible for mixing") |
There was a problem hiding this comment.
I'd include the account in this message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.