This repository was archived by the owner on Oct 28, 2024. It is now read-only.
Remove ellipsis from redirect url#962
Merged
bacongobbler merged 23 commits intodeislabs:mainfrom Jun 29, 2022
Merged
Conversation
Feature / Channel overview page
Signed-off-by: Robert Gogete <[email protected]>
Signed-off-by: Robert Gogete <[email protected]>
…f-screen Bugfix 839/right panel scroll off screen
…rking-as-expected Bugfix 849/update channel not working as expected
Now getting status of the job from Nomad
Signed-off-by: Robert Gogete <[email protected]>
Updated openapi generator
bacongobbler
approved these changes
Jun 29, 2022
|
|
||
| getRedirectRoute(route: string): string { | ||
| if (route) { | ||
| if (route.slice(-3) === '...') { |
Contributor
There was a problem hiding this comment.
for self-reference, this appears to be a safe call. From https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/slice#parameters:
If start is greater than the index range of the sequence, an empty array is returned.
So in cases where route is shorter than an ellipsis, it should jump to the else clause.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #961