Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@greg0ire
Copy link
Contributor

This is the simplest way of getting the psalm language server to run
now.

This is the simplest way of getting the psalm language server to run
now.
@greg0ire
Copy link
Contributor Author

I'm really new to vimL and Vader and have little to no idea what I've been doing.

@greg0ire greg0ire marked this pull request as ready for review July 26, 2019 06:19
Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How recently was the --language-server option added? Will changing this break use of the language server for some users?

@muglug
Copy link
Contributor

muglug commented Aug 18, 2019

It was added 5 months ago - there's a slight risk of breaking existing users but (on the other hand) people should be using the latest version of Psalm (which is still on the same major version as when the plugin was released)

Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I think that's old enough. I'll merge this.

@w0rp w0rp merged commit cebbb67 into dense-analysis:master Oct 7, 2019
@greg0ire greg0ire deleted the psalm-language-server-option branch October 7, 2019 19:42
@greg0ire
Copy link
Contributor Author

greg0ire commented Oct 7, 2019

Haha yeah! It's ripe now!

@w0rp
Copy link
Member

w0rp commented Aug 29, 2020

I only just noticed that the _executable option isn't properly named. It should be g:ale_php_psalm_executable, instead of g:ale_psalm_langserver_executable. Update your settings now if you use that option. I'm about to change that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants