Add ALEPopulateQuickfix and ALEPopulateLocList #3761
Conversation
|
I didn't see the "Custom warnings/errors follow". Fixed. |
|
Fixed trailing whitespace and made test more comprehensive. |
0bd258a to
ceeb7dd
Compare
Resolve dense-analysis#1810. Add ALEPopulateQuickfix and ALEPopulateLocList. They're not very useful with ale's default autopopulate behaviour, so their useful configuration is described in help. Test is based on test_ale_lint_command.vader Manual Test * configure as described in doc * open a file with lint errors * use scriptease's Vedit to populate loc-list * modify and save file - loc-list is preserved * ALEPopulateQuickfix - quickfix is opened with lint * ALEPopulateLocList - loc-list is replaced with lint
|
This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See |
|
@w0rp: I've been using this feature since I implemented it and enjoying it. I have tests and it's working well. Could I get a review? Do you want me to rebase on master first? |
|
Got another user (on #2866) to confirm this PR works for them too. |
|
This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See |
|
I'm using this regularly. I don't love how ALEPopulateQuickfix populates for all open files, but ALEPopulateLocList is very useful. |
|
This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See |
|
@w0rp Still love to get this reviewed and merged. It has tests and documentation. |
|
This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See |
|
Bump to unstale. |
|
Cheers! 🍻 Sorry for not being very active these days. I check random things now and then and I don't have much to add to ALE myself for the moment as it does everything I want it to do for now. |
Resolve #1810.
Add ALEPopulateQuickfix and ALEPopulateLocList. They're not very useful
with ale's default autopopulate behaviour, so their useful configuration
is described in help.
Also fixed an unrelated typo.
Open to changing the command names. I'd suggested ALEShowErrors, but since there's two lists I went with populate. Not sure if it should optionally obey
g:ale_open_list. That setting seems mostly for "don't make windows popup automatically", so I don't have a bang variant.I didn't implement the fancy list target preservation described on the issue. Doing that would improve this feature to keep the list updated while it's displayed, but it seems much more complicated.