Keep -iframework if present in parsed C/C++ flags #3057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 17, 2020 18:47
-iframework appears to implicitly add some header search paths to the
set specified using the -isystem, -I, and -isysroot flags. This means
that leaving out -iframework can result in invalid errors being
displayed.
For example, given a CMake project with this CMakeLists.txt:
project(test)
set(Qt5_DIR "/usr/local/opt/qt5/lib/cmake/Qt5")
find_package(Qt5 5.9 REQUIRED COMPONENTS Widgets)
add_executable(foo foo.cpp)
target_link_libraries(foo PRIVATE Qt5::Widgets)
and foo.cpp:
#include <QWidget>
int main() {}
If g:ale_c_parse_compile_commands is set, then ALE executes something
along these lines:
clang++ -S -x c++ -fsyntax-only -std=gnu++11 -isystem /usr/local/opt/qt5/lib/QtWidgets.framework/Headers - < foo.cpp
Resulting in this output:
In file included from <stdin>:1:
In file included from /usr/local/opt/qt5/lib/QtWidgets.framework/Headers/QWidget:1:
/usr/local/opt/qt5/lib/QtWidgets.framework/Headers/qwidget.h:43:10: fatal error: 'QtWidgets/qtwidgetsglobal.h' file not found
#include <QtWidgets/qtwidgetsglobal.h>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Because the header is in a subdirectory of the path denoted by -isystem
(/usr/local/opt/qt5/lib/QtWidgets.framework/Headers/5.14.1/QtWidgets/qtwidgetsglobal.h),
clang fails to find it and exits.
If -iframework is included, ALE executes something along these lines:
clang++ -S -x c++ -fsyntax-only -std=gnu++11 -iframework /usr/local/opt/qt5/lib -isystem /usr/local/opt/qt5/lib/QtWidgets.framework/Headers - < foo.cpp
And compilation completes successfully.
|
This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See |
|
I think this PR is ready to go? It has tests, though I'm not sure if additional documentation is required beyond that in the commit message. |
w0rp
approved these changes
Aug 19, 2020
|
Cheers! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-iframeworkappears to implicitly add some header search paths to theset specified using the
-isystem,-I, and-isysrootflags. This meansthat leaving out
-iframeworkcan result in invalid errors beingdisplayed.
For example, given a CMake project with this CMakeLists.txt:
and foo.cpp:
If
g:ale_c_parse_compile_commandsis set, then ALE executes somethingalong these lines:
Resulting in this output:
Because the header is in a subdirectory of the path denoted by -isystem
(/usr/local/opt/qt5/lib/QtWidgets.framework/Headers/5.14.1/QtWidgets/qtwidgetsglobal.h),
clang fails to find it and exits.
If -iframework is included, ALE executes something along these lines:
And compilation completes successfully.