Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@3flex
Copy link
Member

@3flex 3flex commented Aug 21, 2021

This was deprecated in detekt 1.3.0 - it's time to say goodbye.

@codecov
Copy link

codecov bot commented Aug 21, 2021

Codecov Report

Merging #4063 (061d84e) into main (026066f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #4063   +/-   ##
=========================================
  Coverage     83.58%   83.58%           
  Complexity     3186     3186           
=========================================
  Files           459      459           
  Lines          9099     9099           
  Branches       1772     1772           
=========================================
  Hits           7605     7605           
  Misses          561      561           
  Partials        933      933           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 026066f...061d84e. Read the comment docs.

@3flex 3flex added this to the 1.19.0 milestone Aug 21, 2021
@cortinico
Copy link
Member

it's time to say goodbye.

Agree.
As a side note: I'm even unsure of how users would use this API in their gradle file. Was it something like?

this.detekt {
    ...
}

Asking as we probably want to add something to the release notes about it

@cortinico cortinico added gradle-plugin notable changes Marker for notable changes in the changelog labels Aug 21, 2021
@3flex
Copy link
Member Author

3flex commented Aug 21, 2021

Was it something like?

It was just:

detekt {

}

The problem is the plugin wasn't being applied correctly by some users, so the type-safe accessors generated for the Kotlin DSL weren't being generated. This is a configuration problem, not something to do with the plugin, but this helper provided a workaround.

The helper isn't necessary if the plugin is applied properly. Users should be familiar with Gradle's Kotlin DSL primer. I'm not sure if we need something in the release notes since the deprecation message has had a link to this document since 2019.

@cortinico cortinico removed the notable changes Marker for notable changes in the changelog label Aug 21, 2021
@cortinico cortinico merged commit 198c53c into detekt:main Aug 21, 2021
@3flex 3flex deleted the remove-extension branch August 21, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants