Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@3flex
Copy link
Member

@3flex 3flex commented Sep 19, 2021

It seems detekt-tooling should be considered public API. This ensures the API is not accidentally changed.

Modules now checked with the binary compatibility validator:

  • detekt-tooling
  • detekt-api
  • detekt-psi-utils

@codecov
Copy link

codecov bot commented Sep 19, 2021

Codecov Report

Merging #4112 (0e3080c) into main (cbdb460) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #4112   +/-   ##
=========================================
  Coverage     83.51%   83.51%           
  Complexity     3186     3186           
=========================================
  Files           461      461           
  Lines          9095     9095           
  Branches       1768     1768           
=========================================
  Hits           7596     7596           
  Misses          570      570           
  Partials        929      929           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbdb460...0e3080c. Read the comment docs.

@BraisGabin
Copy link
Member

A bit off topic but, should we add detekt-test and detekt-test-utils? For example I use both of those in some custom rules: https://github.com/BraisGabin/detekt-junit-rules/blob/main/build.gradle.kts

I'm not sure because they are used to run the tests. With api compatibility should be enough, right?

@3flex
Copy link
Member Author

3flex commented Sep 19, 2021

should we add detekt-test and detekt-test-utils

I think it's worth having the discussion about which APIs need to be strictly maintained, and which don't. That could be a separate issue/discussion.

@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label Sep 22, 2021
@cortinico cortinico added this to the 1.19.0 milestone Sep 22, 2021
@cortinico cortinico merged commit 6e2d00c into detekt:main Sep 22, 2021
@3flex 3flex deleted the validate-tooling branch September 22, 2021 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

housekeeping Marker for housekeeping tasks and refactorings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants