Split InvalidPackageDeclaration to create MissingPackageDeclaration #4149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4149 +/- ##
============================================
+ Coverage 83.44% 83.46% +0.01%
- Complexity 3177 3179 +2
============================================
Files 465 466 +1
Lines 9104 9114 +10
Branches 1775 1775
============================================
+ Hits 7597 7607 +10
Misses 572 572
Partials 935 935
Continue to review full report at Codecov.
|
marschwar
approved these changes
Oct 4, 2021
cortinico
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InvalidPackageDeclarationwas doing two different things. With this PR we split that responsability in two different rules.I created the new rule
MissingPackageDeclarationinside the error prone rule set, do you agree?Closes #3957