ObjectLiteralToLambda: fix false positive when using Java interfaces with default methods#4203
Merged
chao2zhang merged 2 commits intodetekt:mainfrom Oct 29, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4203 +/- ##
============================================
- Coverage 84.20% 84.19% -0.02%
+ Complexity 3233 3231 -2
============================================
Files 468 468
Lines 10183 10181 -2
Branches 1785 1784 -1
============================================
- Hits 8575 8572 -3
Misses 669 669
- Partials 939 940 +1
Continue to review full report at Codecov.
|
eaf4c85 to
341e165
Compare
…with default methods
341e165 to
6d3d1d4
Compare
BraisGabin
reviewed
Oct 28, 2021
| override fun foo() { | ||
| println() | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
I have no idea about this. Isn't it possible to use SAM when the interface has only one method but it has a default?
Contributor
Author
There was a problem hiding this comment.
A default method is not an abstract method.
d751f27 to
6c64ab3
Compare
BraisGabin
approved these changes
Oct 29, 2021
chao2zhang
approved these changes
Oct 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4161