Simplify YamlConfig #4316
Merged
Simplify YamlConfig #4316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4316 +/- ##
============================================
- Coverage 84.22% 84.20% -0.02%
Complexity 3258 3258
============================================
Files 472 473 +1
Lines 10309 10309
Branches 1820 1821 +1
============================================
- Hits 8683 8681 -2
Misses 666 666
- Partials 960 962 +2
Continue to review full report at Codecov.
|
6fe2866 to
65bf336
Compare
65bf336 to
da6604b
Compare
chao2zhang
reviewed
Nov 22, 2021
detekt-core/src/main/kotlin/io/gitlab/arturbosch/detekt/core/config/Configurations.kt
Outdated
Show resolved
Hide resolved
chao2zhang
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YamlConfig.loadResource(URL)is not needed as method. We can useYamlConfig.load(Reader)and convert the URLs to readers when calling.This is part of the refactor to implement #4315