Thanks to visit codestin.com
Credit goes to github.com

Skip to content

update InvalidPackageDeclaration to report if rootPackage is not present #4484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cortinico merged 5 commits into from
Feb 7, 2022
Merged

update InvalidPackageDeclaration to report if rootPackage is not present #4484

cortinico merged 5 commits into from
Feb 7, 2022

Conversation

@mateot1
Copy link
Contributor

@mateot1 mateot1 commented Jan 11, 2022

This should fix the issue I just opened here: #4483

@cortinico cortinico mentioned this pull request Jan 12, 2022
Closed
@codecov
Copy link

codecov bot commented Jan 14, 2022 •
edited
Loading

Codecov Report

Merging #4484 (7beeee0) into main (56e7fa9) will increase coverage by 84.44%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #4484       +/-   ##
===========================================
+ Coverage        0   84.44%   +84.44%     
- Complexity      0     3329     +3329     
===========================================
  Files           0      479      +479     
  Lines           0    11147    +11147     
  Branches        0     2040     +2040     
===========================================
+ Hits            0     9413     +9413     
- Misses          0      700      +700     
- Partials        0     1034     +1034
Impacted Files Coverage Δ
...h/detekt/rules/naming/InvalidPackageDeclaration.kt 96.77% <100.00%> (ø)
.../arturbosch/detekt/core/baseline/BaselineFacade.kt 85.71% <0.00%> (ø)
.../arturbosch/detekt/core/config/ConfigValidators.kt 84.21% <0.00%> (ø)
...ab/arturbosch/detekt/rules/bugs/HasPlatformType.kt 68.00% <0.00%> (ø)
.../detekt/rules/naming/ConstructorParameterNaming.kt 96.77% <0.00%> (ø)
...ls/src/main/kotlin/io/github/detekt/psi/KtFiles.kt 75.00% <0.00%> (ø)
...lab/arturbosch/detekt/core/rules/RuleSetLocator.kt 87.50% <0.00%> (ø)
...b/detekt/metrics/processors/ProjectLOCProcessor.kt 100.00% <0.00%> (ø)
...detekt/metrics/processors/PackageCountProcessor.kt 93.75% <0.00%> (ø)
...ain/kotlin/io/github/detekt/metrics/LinesOfCode.kt 95.45% <0.00%> (ø)
... and 470 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56e7fa9...7beeee0. Read the comment docs.

@mateot1
Copy link
Contributor Author

mateot1 commented Feb 3, 2022

sorry for the delay. I updated this to use a new config field and added a default to default-detekt-config.yml. let me know if there's anything I missed for adding a new config field.

@cortinico cortinico added this to the 1.20.0 milestone Feb 4, 2022
@cortinico cortinico added the rules label Feb 4, 2022
@cortinico cortinico merged commit dfd1966 into detekt:main Feb 7, 2022
Goooler pushed a commit to Goooler/detekt that referenced this pull request Feb 10, 2022
@mateot1 @Goooler
update InvalidPackageDeclaration to report if rootPackage is not pres…
de65436 
…ent (detekt#4484)
@mateot1 mateot1 deleted the invalid-package-enforce-root-package branch May 14, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marschwar marschwar marschwar left review comments

@BraisGabin BraisGabin BraisGabin approved these changes

@cortinico cortinico cortinico approved these changes

Assignees

No one assigned

Labels

rules

Projects

None yet

Milestone

1.20.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mateot1 @BraisGabin @cortinico @marschwar