Update MagicNumber rule to exclude .kts files #4877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MagicNumber rule should not be enforced in script files, because you cannot have constants in these files. Closes #4863
Member
|
This file is autogenerated, it is not that easy to add this change. |
cortinico
previously approved these changes
May 31, 2022
Member
|
Yup @BraisGabin is right. Though this might help: (not sure if we merge exclusions though) |
Member
Author
|
Thanks for the hint, guys. I hadn't changed something in the
|
cortinico
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MagicNumber rule should not be enforced in script files,
because you cannot have constants in these files.
Closes #4863