Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Declare nested test classes as non-static #4894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
schalkms merged 1 commit into from
Jun 1, 2022
Merged

Declare nested test classes as non-static #4894

schalkms merged 1 commit into from
Jun 1, 2022

Conversation

@schalkms
Copy link
Member

@schalkms schalkms commented Jun 1, 2022

The @nested annotation cannot be used on static classes.

@schalkms
Declare nested test classes as non-static
9fffc61 
The @nested annotation cannot be used on static classes.
@schalkms schalkms added this to the 1.21.0 milestone Jun 1, 2022
@codecov
Copy link

codecov bot commented Jun 1, 2022 •
edited
Loading

Codecov Report

Merging #4894 (9fffc61) into main (16b6658) will increase coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #4894      +/-   ##
============================================
+ Coverage     84.73%   84.80%   +0.06%     
- Complexity     3480     3488       +8     
============================================
  Files           495      495              
  Lines         11464    11464              
  Branches       2122     2122              
============================================
+ Hits           9714     9722       +8     
  Misses          685      685              
+ Partials       1065     1057       -8
Impacted Files Coverage Δ
...gitlab/arturbosch/detekt/rules/style/UseOrEmpty.kt 74.07% <0.00%> (ø)
...gitlab/arturbosch/detekt/rules/style/UseRequire.kt 94.11% <0.00%> (ø)
...b/arturbosch/detekt/rules/style/UseCheckNotNull.kt 92.30% <0.00%> (ø)
...b/arturbosch/detekt/rules/style/UseCheckOrError.kt 85.71% <0.00%> (ø)
.../arturbosch/detekt/rules/style/UseIsNullOrEmpty.kt 57.14% <0.00%> (ø)
...arturbosch/detekt/rules/style/UnnecessaryFilter.kt 80.55% <0.00%> (ø)
...arturbosch/detekt/rules/style/UseRequireNotNull.kt 92.30% <0.00%> (ø)
...rbosch/detekt/rules/style/ObjectLiteralToLambda.kt 81.08% <0.00%> (ø)
...arturbosch/detekt/rules/bugs/IgnoredReturnValue.kt 82.85% <0.00%> (ø)
...rturbosch/detekt/rules/bugs/UnusedUnaryOperator.kt 66.66% <0.00%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16b6658...9fffc61. Read the comment docs.

@schalkms schalkms merged commit 4cc4051 into main Jun 1, 2022
@schalkms schalkms deleted the nested branch June 1, 2022 21:51
@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BraisGabin BraisGabin BraisGabin approved these changes

Assignees

No one assigned

Labels

housekeeping Marker for housekeeping tasks and refactorings

Projects

None yet

Milestone

1.21.0

Development

Successfully merging this pull request may close these issues.

4 participants

@schalkms @BraisGabin @cortinico